From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Tweak gdb.trace/tfile.c for thumb mode
Date: Wed, 16 Jul 2014 05:19:00 -0000 [thread overview]
Message-ID: <53C5E05F.3050504@codesourcery.com> (raw)
In-Reply-To: <53C5DC6F.6060007@codesourcery.com>
On 07/15/2014 09:01 PM, Pedro Alves wrote:
> /* FIXME need a portable way to print function address in hex */
Happen to see that we can remove the FIXME too.
> - func_addr = (long) &write_basic_trace_file;
> -#if defined(__thumb__) || defined(__thumb2__)
> - /* Although Thumb functions are two-byte aligned, function
> - pointers have the Thumb bit set. Clear it. */
> - func_addr &= ~1;
> -#endif
> + func_addr = FUNCTION_ADDRESS (write_basic_trace_file);
--
Yao (é½å°§)
next prev parent reply other threads:[~2014-07-16 2:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 3:52 Yao Qi
2014-07-09 11:55 ` Yao Qi
2014-07-09 14:52 ` Pedro Alves
2014-07-10 1:30 ` Yao Qi
2014-07-15 13:20 ` Pedro Alves
2014-07-15 14:16 ` Yao Qi
2014-07-15 14:38 ` Pedro Alves
2014-07-16 2:19 ` Yao Qi
2014-07-16 5:19 ` Yao Qi [this message]
2014-07-16 19:02 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C5E05F.3050504@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox