Re: [PATCH] Tweak gdb.trace/tfile.c for thumb mode

Yao Qi
2014-07-16T02:19:30Z

On 07/15/2014 09:01 PM, Pedro Alves wrote:

> /* FIXME need a portable way to print function address in hex */

Happen to see that we can remove the FIXME too.

> - func_addr = (long) &write_basic_trace_file;
> -#if defined(__thumb__) || defined(__thumb2__)
> - /* Although Thumb functions are two-byte aligned, function
> - pointers have the Thumb bit set. Clear it. */
> - func_addr &= ~1;
> -#endif
> + func_addr = FUNCTION_ADDRESS (write_basic_trace_file);

--
Yao (é½å°§)