Re: [PATCH] Tweak gdb.trace/tfile.c for thumb mode

Yao Qi
2014-07-15T14:00:04Z

On 07/15/2014 09:01 PM, Pedro Alves wrote:
> While doing
> that I noticed that write_error_trace_file needs the Thumb
> treatment too?
>

Yes, that is correct.

> WDYT of the patch below? I don't think we need to worry about
> targets that don't have stdint.h in this test and at this
> day and age.

The patch looks good to me. Thanks.

> The rest is just enough changes to make the file build without
> warnings with "-Wall -Wextra" with x86_64-w64-mingw32-gcc and
> i686-w64-mingw32-gcc cross compilers, and with -m32/-m64 on x86_64
> GNU/Linux. Currently with x86_64-w64-mingw32-gcc we get:

Make sure I understand you correctly, you fixed warnings on mingw32 but
didn't run the test on mingw32, did you?

--
Yao (é½å°§)