From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10423 invoked by alias); 16 Jul 2014 02:19:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10060 invoked by uid 89); 16 Jul 2014 02:19:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Jul 2014 02:19:19 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1X7EoO-0000RG-7R from Yao_Qi@mentor.com ; Tue, 15 Jul 2014 19:19:16 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 15 Jul 2014 19:19:15 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.2.247.3; Tue, 15 Jul 2014 19:18:29 -0700 Message-ID: <53C5E05F.3050504@codesourcery.com> Date: Wed, 16 Jul 2014 05:19:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Pedro Alves , Subject: Re: [PATCH] Tweak gdb.trace/tfile.c for thumb mode References: <1404100222-2312-1-git-send-email-yao@codesourcery.com> <53BD5710.5040105@redhat.com> <53BDEBD8.5030201@codesourcery.com> <53C52622.3000405@redhat.com> <53C53319.7090001@codesourcery.com> <53C537A1.9080802@redhat.com> <53C5DC6F.6060007@codesourcery.com> In-Reply-To: <53C5DC6F.6060007@codesourcery.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00409.txt.bz2 On 07/15/2014 09:01 PM, Pedro Alves wrote: > /* FIXME need a portable way to print function address in hex */ Happen to see that we can remove the FIXME too. > - func_addr = (long) &write_basic_trace_file; > -#if defined(__thumb__) || defined(__thumb2__) > - /* Although Thumb functions are two-byte aligned, function > - pointers have the Thumb bit set. Clear it. */ > - func_addr &= ~1; > -#endif > + func_addr = FUNCTION_ADDRESS (write_basic_trace_file); -- Yao (齐尧)