From: Pierre Langlois <pierre.langlois@embecosm.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Add support for the __flash qualifier on AVR
Date: Tue, 15 Jul 2014 15:56:00 -0000 [thread overview]
Message-ID: <53C54EDD.3010506@embecosm.com> (raw)
In-Reply-To: <20140715145904.GF4888@adacore.com>
>> +static int
>> +avr_address_class_type_flags (int byte_size, int dwarf2_addr_class)
>> +{
>> + /* The value 1 of the DW_AT_address_class attribute corresponds to the __flash
>
> This line is too long (81 chars?)
>
This line is exactly 80 chars. I will reformat this comment with a limit of 74
chars, 80 chars do not really help readability in this case.
Thank you for your patience with my formatting issues! I will post the final
correct patch on this thread when I have pushed it.
Pierre
next prev parent reply other threads:[~2014-07-15 15:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 10:54 [PATCH] " Pierre Langlois
2014-07-15 10:36 ` [PING][PATCH] " Pierre Langlois
2014-07-15 14:00 ` [PATCH] " Joel Brobecker
2014-07-15 14:46 ` Pierre Langlois
2014-07-15 14:59 ` [PATCH v2] " Pierre Langlois
2014-07-15 15:01 ` Joel Brobecker
2014-07-15 15:56 ` Pierre Langlois [this message]
2014-07-15 16:42 ` [PUSHED] " Pierre Langlois
2014-07-21 16:02 ` [PATCH] " Pedro Alves
2014-07-23 17:42 ` Pierre Langlois
2014-07-24 1:35 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C54EDD.3010506@embecosm.com \
--to=pierre.langlois@embecosm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox