From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14982 invoked by alias); 15 Jul 2014 15:55:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14965 invoked by uid 89); 15 Jul 2014 15:55:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: mail-wg0-f41.google.com Received: from mail-wg0-f41.google.com (HELO mail-wg0-f41.google.com) (74.125.82.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 15 Jul 2014 15:55:14 +0000 Received: by mail-wg0-f41.google.com with SMTP id z12so5888224wgg.24 for ; Tue, 15 Jul 2014 08:55:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=i7MlNvqjYKJfJIwDoGsU2uzQkVocLYkZ3SS8HbOcWc4=; b=Rntpd+Us+tGvHg36U9lXiwz6crICk1/8GsgreBl48liOtcFBA97THYRLCzJNoT2eKw 8QrGxK1yzMQFwiUxf56aVJc+bDLMeWnOtpEBZAWBv/Yl/Jf2ysGzRpDOW1nQ8ia6Q27a e4BhcpQTeaOLqH5eCC4Gp5Ve0sYoYlT6dut6V6AFikgESASA7FPF2j+MPk4+xOmV5RlW TDn1eVH2ERuoQDUJnEp1ot52xY4I+fEjKUH0kFjzA76HVr5mZDuyjEkktgN7AtNJzTsf NhUIG85h5svEVc0vL5IzrltzBEfatt/gp4CpP1i93tI62CaDGwJiIX1U2Zhv2hmYdF5E axnQ== X-Gm-Message-State: ALoCoQlVrHaI8/m97qRxHOaUW9/d7e+72drg+Mg6UEBHWghkrVahekUBxhB5SowcRxI6Jk1mwDcn X-Received: by 10.194.158.101 with SMTP id wt5mr4609954wjb.136.1405439710971; Tue, 15 Jul 2014 08:55:10 -0700 (PDT) Received: from [192.168.0.9] (cust64-dsl91-135-5.idnet.net. [91.135.5.64]) by mx.google.com with ESMTPSA id jy8sm33462637wjc.7.2014.07.15.08.55.09 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 15 Jul 2014 08:55:10 -0700 (PDT) Message-ID: <53C54EDD.3010506@embecosm.com> Date: Tue, 15 Jul 2014 15:56:00 -0000 From: Pierre Langlois User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [PATCH v2] Add support for the __flash qualifier on AVR References: <1404816844-1639-1-git-send-email-pierre.langlois@embecosm.com> <1405435683-10535-1-git-send-email-pierre.langlois@embecosm.com> <20140715145904.GF4888@adacore.com> In-Reply-To: <20140715145904.GF4888@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00395.txt.bz2 >> +static int >> +avr_address_class_type_flags (int byte_size, int dwarf2_addr_class) >> +{ >> + /* The value 1 of the DW_AT_address_class attribute corresponds to the __flash > > This line is too long (81 chars?) > This line is exactly 80 chars. I will reformat this comment with a limit of 74 chars, 80 chars do not really help readability in this case. Thank you for your patience with my formatting issues! I will post the final correct patch on this thread when I have pushed it. Pierre