Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pierre Langlois <pierre.langlois@embecosm.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Add support for the __flash qualifier on AVR
Date: Tue, 15 Jul 2014 14:46:00 -0000	[thread overview]
Message-ID: <53C53D13.8070501@embecosm.com> (raw)
In-Reply-To: <20140715133316.GE4888@adacore.com>

Hello Joel,

>
> Sorry about the delay in reviewing this. Some comments below.
>

That's OK, thank you very much for the review!

>> +  // __flash qualifier
>
> Please do not use C++-style comments for the moment.
>

Oh dear, I'm sorry about this.

Thanks,

Pierre


  reply	other threads:[~2014-07-15 14:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-08 10:54 Pierre Langlois
2014-07-15 10:36 ` [PING][PATCH] " Pierre Langlois
2014-07-15 14:00 ` [PATCH] " Joel Brobecker
2014-07-15 14:46   ` Pierre Langlois [this message]
2014-07-15 14:59 ` [PATCH v2] " Pierre Langlois
2014-07-15 15:01   ` Joel Brobecker
2014-07-15 15:56     ` Pierre Langlois
2014-07-15 16:42 ` [PUSHED] " Pierre Langlois
2014-07-21 16:02 ` [PATCH] " Pedro Alves
2014-07-23 17:42   ` Pierre Langlois
2014-07-24  1:35     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C53D13.8070501@embecosm.com \
    --to=pierre.langlois@embecosm.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox