From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18819 invoked by alias); 15 Jul 2014 14:39:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18689 invoked by uid 89); 15 Jul 2014 14:39:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: mail-we0-f181.google.com Received: from mail-we0-f181.google.com (HELO mail-we0-f181.google.com) (74.125.82.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 15 Jul 2014 14:39:21 +0000 Received: by mail-we0-f181.google.com with SMTP id q59so5621949wes.26 for ; Tue, 15 Jul 2014 07:39:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=tgEuANHdDv+/PGSIKBeGzTYqvHG1Rt+pqoVHrazvkrM=; b=b+/IOhFW/vU8LqdXvWqXu6UThiC4CezTg4etd73yq4FunGxMcJqJVwmrKpBWlTGokv Br/lv+nEVlxaeh53YhLQu+A9IH5sNDwcTmQzWVxc8EuAdbU7SbNs1Y/I87bNm3NShAOJ CPFxuszSMD1M5FH+izs1K7X9f8HHB8gtMZ6guI9CYKOFCviG5iutQfiVONMaYlaNPBac X0l9cochl0aX/+C0+BXQAn22ckknLqe2MHdiTv3OGi72XzPwov26+VhmUd4Wqodyzz3h +xjyYEJOA2Arz2UbC6kXtYtEp6JPG25AgpiGwfZrY0l7yABblPsZhoNIwvJnhxDRfool Qs/g== X-Gm-Message-State: ALoCoQnzAvFPhH+nPe+DYi6yOr+U11m9+TS68mKOytgrvwV/4TBoNf+Vxr9sutxNrKMtYF99Q/iO X-Received: by 10.180.21.200 with SMTP id x8mr6091678wie.67.1405435157538; Tue, 15 Jul 2014 07:39:17 -0700 (PDT) Received: from [192.168.0.9] (cust64-dsl91-135-5.idnet.net. [91.135.5.64]) by mx.google.com with ESMTPSA id ft6sm11541469wic.0.2014.07.15.07.39.16 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 15 Jul 2014 07:39:16 -0700 (PDT) Message-ID: <53C53D13.8070501@embecosm.com> Date: Tue, 15 Jul 2014 14:46:00 -0000 From: Pierre Langlois User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Add support for the __flash qualifier on AVR References: <1404816844-1639-1-git-send-email-pierre.langlois@embecosm.com> <20140715133316.GE4888@adacore.com> In-Reply-To: <20140715133316.GE4888@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00380.txt.bz2 Hello Joel, > > Sorry about the delay in reviewing this. Some comments below. > That's OK, thank you very much for the review! >> + // __flash qualifier > > Please do not use C++-style comments for the moment. > Oh dear, I'm sorry about this. Thanks, Pierre