From: Pedro Alves <palves@redhat.com>
To: Gary Benson <gbenson@redhat.com>, gdb-patches@sourceware.org
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [PATCH 0/7 v2] Refactor shared code in {i386,amd64}-linux-nat.c
Date: Wed, 09 Jul 2014 13:17:00 -0000 [thread overview]
Message-ID: <53BD40E6.8000701@redhat.com> (raw)
In-Reply-To: <1403878351-22974-1-git-send-email-gbenson@redhat.com>
On 06/27/2014 03:12 PM, Gary Benson wrote:
> Hi all,
>
> This series is an updated version of the series I posted this morning.
> Mark Kettenis rightly pointed out that x86_linux_read_description was
> a mess of #ifdef spaghetti so I have rewritten it.
>
> Patch 2 has changed because that's where the x86_linux_read_description
> merge is. Patch 6 has changed because that's where the code is pulled
> from {i386,amd64}-linux-nat.c into x86-linux-nat.c. The remaining
> patches are the same.
>
> I've inlined the original description of the series below.
>
> Is this ok to commit?
I read this, and apart from a couple nits, it all looked good to me.
I think we can take Mark's silence as meaning his objections have
been addressed, but in case he just didn't have time to reply, let's
wait till Friday, and then push this in.
Thanks!
--
Pedro Alves
next prev parent reply other threads:[~2014-07-09 13:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 14:12 Gary Benson
2014-06-27 14:12 ` [PATCH 2/7 v2] Merge {i386,amd64}_linux_read_description Gary Benson
2014-07-09 13:07 ` Pedro Alves
2014-06-27 14:12 ` [PATCH 1/7 v2] Rename identical functions Gary Benson
2014-07-09 13:04 ` Pedro Alves
2014-06-27 14:12 ` [PATCH 3/7 v2] Merge ps_get_thread_area Gary Benson
2014-07-09 13:08 ` Pedro Alves
2014-07-09 13:08 ` Pedro Alves
2014-06-27 14:28 ` [PATCH 6/7 v2] Move duplicated code into new files Gary Benson
2014-07-09 13:12 ` Pedro Alves
2014-06-27 14:40 ` [PATCH 5/7 v2] Comment and whitespace changes Gary Benson
2014-07-09 13:11 ` Pedro Alves
2014-06-27 14:52 ` [PATCH 7/7 v2] Tidy #include lists Gary Benson
2014-07-09 13:13 ` Pedro Alves
2014-08-06 9:36 ` Yao Qi
2014-08-06 10:19 ` Gary Benson
2014-08-06 11:16 ` Yao Qi
2014-09-09 15:09 ` [pushed] Fix missing "struct iovec" definition on some x86-linux. (was: "[PATCH 7/7 v2] Tidy #include lists") Joel Brobecker
2014-09-10 10:59 ` Gary Benson
2014-09-10 13:14 ` Joel Brobecker
2014-06-27 14:53 ` [PATCH 4/7 v2] Pull out common parts of _initialize_{i386,amd64}_linux_nat Gary Benson
2014-07-09 13:09 ` Pedro Alves
2014-07-09 13:17 ` Pedro Alves [this message]
2014-07-11 12:34 ` [PATCH 0/7 v2] Refactor shared code in {i386,amd64}-linux-nat.c Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BD40E6.8000701@redhat.com \
--to=palves@redhat.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox