Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Gary Benson <gbenson@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [pushed] Fix missing "struct iovec" definition on some x86-linux. (was: "[PATCH 7/7 v2] Tidy #include lists")
Date: Wed, 10 Sep 2014 13:14:00 -0000	[thread overview]
Message-ID: <20140910131410.GA26248@adacore.com> (raw)
In-Reply-To: <20140910105903.GA30066@blade.nx>

[-- Attachment #1: Type: text/plain, Size: 744 bytes --]

> > > This commit tidies up the #include lists in {i386,amd64}-linux-nat.c,
> > > removing headers that are no longer required and reordering some
> > > lines so that both files roughly match.  Additionally, an unused
> > > definition was removed from the middle of the #include list in
> > > i386-linux-nat.c.
> > 
> > Unfortunately, this patch broke GDB builds on some GNU/Linux
> > distros. I fixed the issue I got by applying the attached patch.
> 
> Thanks for fixing this Joel.

Of course! As it happens, we need to do the same for amd64-linux-nat.c
as well. It makes sense, not sure why I didn't think of that before.
Attached is the patch I just pushed.

gdb/ChangeLog:

        * amd64-linux-nat.c: Add <sys/uio.h> #include.

-- 
Joel

[-- Attachment #2: 0001-Add-sys-uio.h-include-back-in-amd64-linux-nat.c.patch --]
[-- Type: text/x-diff, Size: 1099 bytes --]

From 35782f1465dd014737fcf6c82bdf733598a5c9b8 Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Wed, 10 Sep 2014 09:06:50 -0400
Subject: [PATCH] Add <sys/uio.h> #include back in amd64-linux-nat.c.

This include is needed to access the definition of "struct iovec".

gdb/ChangeLog:

        * amd64-linux-nat.c: Add <sys/uio.h> #include.
---
 gdb/ChangeLog         | 4 ++++
 gdb/amd64-linux-nat.c | 1 +
 2 files changed, 5 insertions(+)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 93a3931..2d20b1c 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2014-09-10  Joel Brobecker  <brobecker@adacore.com>
+
+	* amd64-linux-nat.c: Add <sys/uio.h> #include.
+
 2014-09-09  Doug Evans  <xdje42@gmail.com>
 
 	PR guile/17367
diff --git a/gdb/amd64-linux-nat.c b/gdb/amd64-linux-nat.c
index a00fbd6..09a4dfd 100644
--- a/gdb/amd64-linux-nat.c
+++ b/gdb/amd64-linux-nat.c
@@ -22,6 +22,7 @@
 #include "inferior.h"
 #include "regcache.h"
 #include "elf/common.h"
+#include <sys/uio.h>
 #include <sys/ptrace.h>
 #include <asm/prctl.h>
 #include <sys/reg.h>
-- 
1.9.1


  reply	other threads:[~2014-09-10 13:14 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-27 14:12 [PATCH 0/7 v2] Refactor shared code in {i386,amd64}-linux-nat.c Gary Benson
2014-06-27 14:12 ` [PATCH 1/7 v2] Rename identical functions Gary Benson
2014-07-09 13:04   ` Pedro Alves
2014-06-27 14:12 ` [PATCH 2/7 v2] Merge {i386,amd64}_linux_read_description Gary Benson
2014-07-09 13:07   ` Pedro Alves
2014-06-27 14:12 ` [PATCH 3/7 v2] Merge ps_get_thread_area Gary Benson
2014-07-09 13:08   ` Pedro Alves
2014-07-09 13:08   ` Pedro Alves
2014-06-27 14:28 ` [PATCH 6/7 v2] Move duplicated code into new files Gary Benson
2014-07-09 13:12   ` Pedro Alves
2014-06-27 14:40 ` [PATCH 5/7 v2] Comment and whitespace changes Gary Benson
2014-07-09 13:11   ` Pedro Alves
2014-06-27 14:52 ` [PATCH 7/7 v2] Tidy #include lists Gary Benson
2014-07-09 13:13   ` Pedro Alves
2014-08-06  9:36   ` Yao Qi
2014-08-06 10:19     ` Gary Benson
2014-08-06 11:16       ` Yao Qi
2014-09-09 15:09   ` [pushed] Fix missing "struct iovec" definition on some x86-linux. (was: "[PATCH 7/7 v2] Tidy #include lists") Joel Brobecker
2014-09-10 10:59     ` Gary Benson
2014-09-10 13:14       ` Joel Brobecker [this message]
2014-06-27 14:53 ` [PATCH 4/7 v2] Pull out common parts of _initialize_{i386,amd64}_linux_nat Gary Benson
2014-07-09 13:09   ` Pedro Alves
2014-07-09 13:17 ` [PATCH 0/7 v2] Refactor shared code in {i386,amd64}-linux-nat.c Pedro Alves
2014-07-11 12:34   ` Gary Benson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140910131410.GA26248@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gbenson@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox