Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH] Handle powerpc branch instruction on gdb.trace/entry-values.exp
@ 2014-07-01 13:22 Luis Machado
  2014-07-01 16:26 ` Tom Tromey
  0 siblings, 1 reply; 2+ messages in thread
From: Luis Machado @ 2014-07-01 13:22 UTC (permalink / raw)
  To: 'gdb-patches@sourceware.org'

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

Hi,

This testcase currently does not handle powerpc branches. It kinda does 
in a way, because the arm/aarch64 branch instruction is the same as 
powerpc's, but the target triplet pattern is not there.

In summary, the testcase fails to locate the branch offset and causes a 
failure and the early termination of the test.

The following patch adds a separate conditional block for powerpc (to 
keep things organized), allowing the testcase to continue.

I see full passes and 1 unsupported test now (due to lack of tracepoint 
support).

Luis

[-- Attachment #2: entry-values.diff --]
[-- Type: text/x-patch, Size: 626 bytes --]

2014-07-01  Luis Machado  <lgustavo@codesourcery.com>

	* gdb.trace/entry-values.exp: Handle powerpc-specific branch
	instruction.

diff --git a/gdb/testsuite/gdb.trace/entry-values.exp b/gdb/testsuite/gdb.trace/entry-values.exp
index f10ffa6..d648bd1 100644
--- a/gdb/testsuite/gdb.trace/entry-values.exp
+++ b/gdb/testsuite/gdb.trace/entry-values.exp
@@ -79,6 +79,8 @@ if { [istarget "arm*-*-*"] || [istarget "aarch64*-*-*"] } {
     set call_insn "bl"
 } elseif { [istarget "s390*-*-*"] } {
     set call_insn "brasl"
+} elseif { [istarget "powerpc*-*-*"] } {
+    set call_insn "bl"
 } else {
     set call_insn "call"
 }

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-01 16:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-01 13:22 [PATCH] Handle powerpc branch instruction on gdb.trace/entry-values.exp Luis Machado
2014-07-01 16:26 ` Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox