Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Luis Machado <lgustavo@codesourcery.com>
To: "'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>
Subject: [PATCH] Handle powerpc branch instruction on gdb.trace/entry-values.exp
Date: Tue, 01 Jul 2014 13:22:00 -0000	[thread overview]
Message-ID: <53B2B5ED.40607@codesourcery.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

Hi,

This testcase currently does not handle powerpc branches. It kinda does 
in a way, because the arm/aarch64 branch instruction is the same as 
powerpc's, but the target triplet pattern is not there.

In summary, the testcase fails to locate the branch offset and causes a 
failure and the early termination of the test.

The following patch adds a separate conditional block for powerpc (to 
keep things organized), allowing the testcase to continue.

I see full passes and 1 unsupported test now (due to lack of tracepoint 
support).

Luis

[-- Attachment #2: entry-values.diff --]
[-- Type: text/x-patch, Size: 626 bytes --]

2014-07-01  Luis Machado  <lgustavo@codesourcery.com>

	* gdb.trace/entry-values.exp: Handle powerpc-specific branch
	instruction.

diff --git a/gdb/testsuite/gdb.trace/entry-values.exp b/gdb/testsuite/gdb.trace/entry-values.exp
index f10ffa6..d648bd1 100644
--- a/gdb/testsuite/gdb.trace/entry-values.exp
+++ b/gdb/testsuite/gdb.trace/entry-values.exp
@@ -79,6 +79,8 @@ if { [istarget "arm*-*-*"] || [istarget "aarch64*-*-*"] } {
     set call_insn "bl"
 } elseif { [istarget "s390*-*-*"] } {
     set call_insn "brasl"
+} elseif { [istarget "powerpc*-*-*"] } {
+    set call_insn "bl"
 } else {
     set call_insn "call"
 }

             reply	other threads:[~2014-07-01 13:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-01 13:22 Luis Machado [this message]
2014-07-01 16:26 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B2B5ED.40607@codesourcery.com \
    --to=lgustavo@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox