From: Chet Ramey <chet.ramey@case.edu>
To: Chen Gang <gang.chen.5i5j@gmail.com>,
Andreas Schwab <schwab@linux-m68k.org>
Cc: chet.ramey@case.edu, palves@redhat.com,
gdb-patches@sourceware.org, binutils@sourceware.org,
bug-readline@gnu.org, amodra@gmail.com
Subject: Re: [Bug-readline] [PATCH] readline/histfile.c: Check and retry write() operation in history_truncate_file()
Date: Wed, 18 Jun 2014 20:33:00 -0000 [thread overview]
Message-ID: <53A1F78A.8020508@case.edu> (raw)
In-Reply-To: <5397C077.1080702@gmail.com>
On 6/10/14, 10:35 PM, Chen Gang wrote:
> For regular file, write() operation may also fail, so check it too. If
> write() return 0, can simply wait and try again, it should not suspend
> infinitely if environments have no critical issues.
Readline-6.3 checks the return value from write() and returns a non-zero
value to the history_truncate_file caller. I really don't think that
waiting forever if write continues to return 0 is a great idea; an error
return is enough to let the caller deal with it.
Chet
--
``The lyf so short, the craft so long to lerne.'' - Chaucer
``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, ITS, CWRU chet@case.edu http://cnswww.cns.cwru.edu/~chet/
next prev parent reply other threads:[~2014-06-18 20:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 2:36 Chen Gang
2014-06-18 20:33 ` Chet Ramey [this message]
2014-06-19 1:31 ` [Bug-readline] " Chen Gang
2014-06-20 8:58 ` Chen Gang
2014-06-20 21:53 ` Chet Ramey
2014-06-21 2:25 ` Chen Gang
2014-06-21 23:19 ` Chet Ramey
2014-06-22 2:01 ` Chen Gang
2014-06-23 13:57 ` Chet Ramey
2014-06-23 14:59 ` Chen Gang
2014-06-25 22:16 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A1F78A.8020508@case.edu \
--to=chet.ramey@case.edu \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=bug-readline@gnu.org \
--cc=gang.chen.5i5j@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox