From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15862 invoked by alias); 18 Jun 2014 20:33:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15843 invoked by uid 89); 18 Jun 2014 20:33:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mpv2.tis.cwru.edu Received: from mpv2.tis.CWRU.Edu (HELO mpv2.tis.cwru.edu) (129.22.105.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (DES-CBC3-SHA encrypted) ESMTPS; Wed, 18 Jun 2014 20:33:20 +0000 Received: from mpv5.tis.CWRU.Edu (EHLO mpv5.cwru.edu) ([129.22.105.51]) by mpv2.tis.cwru.edu (MOS 4.3.5-GA FastPath queued) with ESMTP id BFZ70241; Wed, 18 Jun 2014 16:33:16 -0400 (EDT) Received: from caleb.INS.CWRU.Edu (EHLO caleb.ins.cwru.edu) ([129.22.8.211]) by mpv5.cwru.edu (MOS 4.3.5-GA FastPath queued) with ESMTP id AXD52175 (AUTH cpr); Wed, 18 Jun 2014 16:33:15 -0400 (EDT) Message-ID: <53A1F78A.8020508@case.edu> Date: Wed, 18 Jun 2014 20:33:00 -0000 From: Chet Ramey Reply-To: chet.ramey@case.edu User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Chen Gang , Andreas Schwab CC: chet.ramey@case.edu, palves@redhat.com, gdb-patches@sourceware.org, binutils@sourceware.org, bug-readline@gnu.org, amodra@gmail.com Subject: Re: [Bug-readline] [PATCH] readline/histfile.c: Check and retry write() operation in history_truncate_file() References: <5397C077.1080702@gmail.com> In-Reply-To: <5397C077.1080702@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Junkmail-Whitelist: YES (by domain whitelist at mpv2.tis.cwru.edu) X-SW-Source: 2014-06/txt/msg00687.txt.bz2 On 6/10/14, 10:35 PM, Chen Gang wrote: > For regular file, write() operation may also fail, so check it too. If > write() return 0, can simply wait and try again, it should not suspend > infinitely if environments have no critical issues. Readline-6.3 checks the return value from write() and returns a non-zero value to the history_truncate_file caller. I really don't think that waiting forever if write continues to return 0 is a great idea; an error return is enough to let the caller deal with it. Chet -- ``The lyf so short, the craft so long to lerne.'' - Chaucer ``Ars longa, vita brevis'' - Hippocrates Chet Ramey, ITS, CWRU chet@case.edu http://cnswww.cns.cwru.edu/~chet/