From: Chen Gang <gang.chen.5i5j@gmail.com>
To: chet.ramey@case.edu
Cc: Andreas Schwab <schwab@linux-m68k.org>,
palves@redhat.com, gdb-patches@sourceware.org,
binutils@sourceware.org, bug-readline@gnu.org, amodra@gmail.com
Subject: Re: [Bug-readline] [PATCH] readline/histfile.c: Check and retry write() operation in history_truncate_file()
Date: Sun, 22 Jun 2014 02:01:00 -0000 [thread overview]
Message-ID: <53A638EF.6050700@gmail.com> (raw)
In-Reply-To: <53A612EF.9070400@case.edu>
On 06/22/2014 07:19 AM, Chet Ramey wrote:
> On 6/20/14, 10:25 PM, Chen Gang wrote:
>
>>> There aren't really any plausible conditions under which write(2) returns
>>> 0 instead of -1 when writing a non-zero number of bytes to a regular file.
>>>
>>
>> Hmm... for me, what you said is acceptable. And the function comment need be
>> changed:
>>
>> "Returns 0 on success, errno or -1 on failure"
>
> history_truncate_file will never return -1.
>
Hmm... do you mean:
"for regular file, write() never return 0, if parameter 'count' > 0?"
or
"if write() return 0, can also return 0 to history_truncate_file()?".
>> And since you will work for it next, is it still necessary to send patch v2 for
>> the temporary fix, at present?
>
> I will take care of making those changes, thanks.
OK, thanks (I need/shall not send patch v2 for it).
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
next prev parent reply other threads:[~2014-06-22 2:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 2:36 Chen Gang
2014-06-18 20:33 ` [Bug-readline] " Chet Ramey
2014-06-19 1:31 ` Chen Gang
2014-06-20 8:58 ` Chen Gang
2014-06-20 21:53 ` Chet Ramey
2014-06-21 2:25 ` Chen Gang
2014-06-21 23:19 ` Chet Ramey
2014-06-22 2:01 ` Chen Gang [this message]
2014-06-23 13:57 ` Chet Ramey
2014-06-23 14:59 ` Chen Gang
2014-06-25 22:16 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A638EF.6050700@gmail.com \
--to=gang.chen.5i5j@gmail.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=bug-readline@gnu.org \
--cc=chet.ramey@case.edu \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox