Re: [PATCH] PR remote/17028: GDB+GDBserver hangs on Windows

[Pedro Alves <palves@redhat.com>]

On 06/11/2014 09:27 AM, Joel Brobecker wrote:
>> Here's my current patch to fix PR remote/17028.
>>
>> It fixes the testcase in the PR for me, but I'm not set up
>> for any sort of automated testing on Windows...
> 
> Thanks a lot for the patch. It looks pretty good to me, and it also
> passed testing with our testsuite.

Great!  Looks like target-async still makes it safe and sound to
7.8 then.  Phew!  :-)

I've pushed it in now, with the log issues you pointed out fixed.

>> I'd push this to my github for easier fetching, but github
>> seems to be busted atm...
> 
> I know you were able to push it, but patches sent via git-send-email
> are fine as far as I am concerned. I find it faster to apply via
> git-am, for instance.

It's fine with me too in general.

Though, when calling for testing I like to make it as easy as possible
for someone "driving by" to test (in this case, you, but other people
could want to test as well).  Applying a patch works OK if the touched
code hasn't changed since the patch was generated, otherwise one
either gets to hunt for the base revision or fix conflicts.
A test branch is immune to that.

Since you ran the testing already, and the patch is in
mainline, that's moot now though.  :-)

Thanks,
-- 
Pedro Alves