From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25989 invoked by alias); 11 Jun 2014 10:17:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25977 invoked by uid 89); 11 Jun 2014 10:17:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Jun 2014 10:17:31 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5BAHSFj030913 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 Jun 2014 06:17:28 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5BAHRFT029400; Wed, 11 Jun 2014 06:17:28 -0400 Message-ID: <53982CB6.3040704@redhat.com> Date: Wed, 11 Jun 2014 10:17:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Joel Brobecker CC: GDB Patches Subject: Re: [PATCH] PR remote/17028: GDB+GDBserver hangs on Windows References: <53974B13.4030502@redhat.com> <20140611082739.GA4709@adacore.com> In-Reply-To: <20140611082739.GA4709@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-06/txt/msg00439.txt.bz2 On 06/11/2014 09:27 AM, Joel Brobecker wrote: >> Here's my current patch to fix PR remote/17028. >> >> It fixes the testcase in the PR for me, but I'm not set up >> for any sort of automated testing on Windows... > > Thanks a lot for the patch. It looks pretty good to me, and it also > passed testing with our testsuite. Great! Looks like target-async still makes it safe and sound to 7.8 then. Phew! :-) I've pushed it in now, with the log issues you pointed out fixed. >> I'd push this to my github for easier fetching, but github >> seems to be busted atm... > > I know you were able to push it, but patches sent via git-send-email > are fine as far as I am concerned. I find it faster to apply via > git-am, for instance. It's fine with me too in general. Though, when calling for testing I like to make it as easy as possible for someone "driving by" to test (in this case, you, but other people could want to test as well). Applying a patch works OK if the touched code hasn't changed since the patch was generated, otherwise one either gets to hunt for the base revision or fix conflicts. A test branch is immune to that. Since you ran the testing already, and the patch is in mainline, that's moot now though. :-) Thanks, -- Pedro Alves