Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] PR remote/17028: GDB+GDBserver hangs on Windows
Date: Wed, 11 Jun 2014 08:27:00 -0000	[thread overview]
Message-ID: <20140611082739.GA4709@adacore.com> (raw)
In-Reply-To: <53974B13.4030502@redhat.com>

> Here's my current patch to fix PR remote/17028.
> 
> It fixes the testcase in the PR for me, but I'm not set up
> for any sort of automated testing on Windows...

Thanks a lot for the patch. It looks pretty good to me, and it also
passed testing with our testsuite.

> I'd push this to my github for easier fetching, but github
> seems to be busted atm...

I know you were able to push it, but patches sent via git-send-email
are fine as far as I am concerned. I find it faster to apply via
git-am, for instance.

> However, on the GDBserver side, we that GDBserver already sent a T05
                                   ^^^ see?

> Now GDB does it's thing and goes back to the event loop.  That calls
               ^^^ its

> gdb/
> 2014-06-10  Pedro Alves  <palves@redhat.com>
> 
> 	PR remote/17028
> 	* ser-mingw.c (net_windows_socket_check_pending): New function.
> 	(net_windows_select_thread): Ignore spurious wakeups.  Use
> 	net_windows_socket_check_pending.
> 	(net_windows_wait_handle): Check for pending events with
> 	ioctlsocket, through net_windows_socket_check_pending, instead of
> 	checking the socket's event.

Thank you!
-- 
Joel


  parent reply	other threads:[~2014-06-11  8:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-10 18:14 Pedro Alves
2014-06-10 18:18 ` Pedro Alves
2014-06-11  8:27 ` Joel Brobecker [this message]
2014-06-11 10:17   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140611082739.GA4709@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox