From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13556 invoked by alias); 11 Jun 2014 08:27:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13454 invoked by uid 89); 11 Jun 2014 08:27:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 11 Jun 2014 08:27:44 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D8FEC116146; Wed, 11 Jun 2014 04:27:42 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id CnXtmSNT87i8; Wed, 11 Jun 2014 04:27:42 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9178E116145; Wed, 11 Jun 2014 04:27:42 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id C26E940F38; Wed, 11 Jun 2014 10:27:39 +0200 (CEST) Date: Wed, 11 Jun 2014 08:27:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: GDB Patches Subject: Re: [PATCH] PR remote/17028: GDB+GDBserver hangs on Windows Message-ID: <20140611082739.GA4709@adacore.com> References: <53974B13.4030502@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53974B13.4030502@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-06/txt/msg00437.txt.bz2 > Here's my current patch to fix PR remote/17028. > > It fixes the testcase in the PR for me, but I'm not set up > for any sort of automated testing on Windows... Thanks a lot for the patch. It looks pretty good to me, and it also passed testing with our testsuite. > I'd push this to my github for easier fetching, but github > seems to be busted atm... I know you were able to push it, but patches sent via git-send-email are fine as far as I am concerned. I find it faster to apply via git-am, for instance. > However, on the GDBserver side, we that GDBserver already sent a T05 ^^^ see? > Now GDB does it's thing and goes back to the event loop. That calls ^^^ its > gdb/ > 2014-06-10 Pedro Alves > > PR remote/17028 > * ser-mingw.c (net_windows_socket_check_pending): New function. > (net_windows_select_thread): Ignore spurious wakeups. Use > net_windows_socket_check_pending. > (net_windows_wait_handle): Check for pending events with > ioctlsocket, through net_windows_socket_check_pending, instead of > checking the socket's event. Thank you! -- Joel