Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: gdb-patches@sourceware.org, Tom Tromey <tromey@redhat.com>
Subject: Re: [PATCH v5] Exit code of exited inferiors in -list-thread-groups
Date: Tue, 03 Jun 2014 15:27:00 -0000	[thread overview]
Message-ID: <538DE972.1040609@redhat.com> (raw)
In-Reply-To: <538CDC9E.9020506@ericsson.com>

On 06/02/2014 09:20 PM, Simon Marchi wrote:
>> > keeping things octal, for consistency with what the user sees in the
>> > console.
> I had forgotten that the exit-code was already displayed somewhere else in the MI. Indeed,
> having the same field in different formats in different records would make a very bad interface.
> 
> Speaking of which, the documentation for the *stopped record does not mention exit-code at
> all. I think it should, since it appears in it when the exit code is not 0.

Yeah.  It only appears in an example of -exec-run:

 @smallexample
 (gdb)
 -exec-run
 ^running
 (gdb)
 x = 55
 *stopped,reason="exited",exit-code="01"
 (gdb)
 @end smallexample

> 
>> > (Note you had missed updating at least one example in the manual.)
> I am not sure I understand. The examples in the -list-thread-groups command section? If so, I
> believe they should not contain a exit-code field, as the process is running.

I meant the -exec-run example above.  But that was kind of me getting
confused, as the patch doesn't change the output in that case.  So read
that as me pointing out a place in the manual where we show the result
in octal, that would need updating if we ever want to change the
output format consistently.  :-)

-- 
Pedro Alves


  reply	other threads:[~2014-06-03 15:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-13 21:56 Simon Marchi
2014-05-14  2:51 ` Eli Zaretskii
2014-05-16 20:31 ` Tom Tromey
2014-05-21 17:34   ` Simon Marchi
2014-05-21 18:09     ` Pedro Alves
2014-05-23 18:57       ` Simon Marchi
2014-06-02 18:30       ` Simon Marchi
2014-06-02 18:37         ` Eli Zaretskii
2014-06-02 19:23         ` Pedro Alves
2014-06-02 20:20           ` Simon Marchi
2014-06-03 15:27             ` Pedro Alves [this message]
2014-06-04 18:09           ` Tom Tromey
2014-09-29 21:43             ` Simon Marchi
2014-09-29 21:45               ` Simon Marchi
2014-09-30  2:36                 ` Eli Zaretskii
2014-10-01 14:26                   ` [PATCH v5][pushed] " Simon Marchi
2014-10-13  3:22                     ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=538DE972.1040609@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@ericsson.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox