From: Eli Zaretskii <eliz@gnu.org>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: gdb-patches@sourceware.org, simon.marchi@ericsson.com
Subject: Re: [PATCH v5] Exit code of exited inferiors in -list-thread-groups
Date: Wed, 14 May 2014 02:51:00 -0000 [thread overview]
Message-ID: <8361l9oyx0.fsf@gnu.org> (raw)
In-Reply-To: <1400018204-29559-1-git-send-email-simon.marchi@ericsson.com>
> From: Simon Marchi <simon.marchi@ericsson.com>
> CC: Simon Marchi <simon.marchi@ericsson.com>
> Date: Tue, 13 May 2014 17:56:44 -0400
>
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -108,6 +108,11 @@ PowerPC64 GNU/Linux little-endian powerpc64le-*-linux*
> and "assf"), have been deprecated. Use the "sharedlibrary" command, or
> its alias "share", instead.
>
> +* MI changes
> +
> + ** The -list-thread-groups command outputs an exit-code field for
> + inferiors that have exited.
> +
> *** Changes in GDB 7.7
This part is OK.
> +@item exit-code
> +The exit code of this thread group when it last exited. This field is
> +only present for thread groups of type @samp{process} and only if the
> +process is not running.
This is backwards, and the 1st sentence is confusing until you read
the second one. I suggest to reword like this:
If this thread group is a @samp{process} that exited, this field is
the exit code of that inferior process. Otherwise, the field is not
present.
The documentation part is OK with this change.
next prev parent reply other threads:[~2014-05-14 2:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 21:56 Simon Marchi
2014-05-14 2:51 ` Eli Zaretskii [this message]
2014-05-16 20:31 ` Tom Tromey
2014-05-21 17:34 ` Simon Marchi
2014-05-21 18:09 ` Pedro Alves
2014-05-23 18:57 ` Simon Marchi
2014-06-02 18:30 ` Simon Marchi
2014-06-02 18:37 ` Eli Zaretskii
2014-06-02 19:23 ` Pedro Alves
2014-06-02 20:20 ` Simon Marchi
2014-06-03 15:27 ` Pedro Alves
2014-06-04 18:09 ` Tom Tromey
2014-09-29 21:43 ` Simon Marchi
2014-09-29 21:45 ` Simon Marchi
2014-09-30 2:36 ` Eli Zaretskii
2014-10-01 14:26 ` [PATCH v5][pushed] " Simon Marchi
2014-10-13 3:22 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8361l9oyx0.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox