From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27053 invoked by alias); 3 Jun 2014 15:27:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26938 invoked by uid 89); 3 Jun 2014 15:27:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Jun 2014 15:27:51 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s53FRmlp001371 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 3 Jun 2014 11:27:48 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s53FRko7032274; Tue, 3 Jun 2014 11:27:47 -0400 Message-ID: <538DE972.1040609@redhat.com> Date: Tue, 03 Jun 2014 15:27:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Simon Marchi CC: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH v5] Exit code of exited inferiors in -list-thread-groups References: <1400018204-29559-1-git-send-email-simon.marchi@ericsson.com> <87mweh31qi.fsf@fleche.redhat.com> <537CE38B.7040000@ericsson.com> <537CEBCB.5020401@redhat.com> <538CC2CD.9040309@ericsson.com> <538CCF1F.5000902@redhat.com> <538CDC9E.9020506@ericsson.com> In-Reply-To: <538CDC9E.9020506@ericsson.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-06/txt/msg00089.txt.bz2 On 06/02/2014 09:20 PM, Simon Marchi wrote: >> > keeping things octal, for consistency with what the user sees in the >> > console. > I had forgotten that the exit-code was already displayed somewhere else in the MI. Indeed, > having the same field in different formats in different records would make a very bad interface. > > Speaking of which, the documentation for the *stopped record does not mention exit-code at > all. I think it should, since it appears in it when the exit code is not 0. Yeah. It only appears in an example of -exec-run: @smallexample (gdb) -exec-run ^running (gdb) x = 55 *stopped,reason="exited",exit-code="01" (gdb) @end smallexample > >> > (Note you had missed updating at least one example in the manual.) > I am not sure I understand. The examples in the -list-thread-groups command section? If so, I > believe they should not contain a exit-code field, as the process is running. I meant the -exec-run example above. But that was kind of me getting confused, as the patch doesn't change the output in that case. So read that as me pointing out a place in the manual where we show the result in octal, that would need updating if we ever want to change the output format consistently. :-) -- Pedro Alves