From: Yao Qi <yao@codesourcery.com>
To: Andreas Arnez <arnez@linux.vnet.ibm.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH 01/12] regcache: Add functions suitable for regset_supply/collect.
Date: Tue, 27 May 2014 02:49:00 -0000 [thread overview]
Message-ID: <5383FC9B.4040400@codesourcery.com> (raw)
In-Reply-To: <1401122208-2481-2-git-send-email-arnez@linux.vnet.ibm.com>
On 05/27/2014 12:36 AM, Andreas Arnez wrote:
> +/* Mapping between register numbers and offsets in a buffer, for use
> + in the '*regset' functions below. The first entry in a map refers
> + to offset 0, and each entry increases the offset by its size.
Except that 'regno' is REGCACHE_MAP_SKIP_BYTES. When 'regno' is
REGCACHE_MAP_SKIP_BYTES, 'count' is the increased offset by bytes, IIUC.
> +/* Transfer a set of registers (as described by REGSET) between
> + REGCACHE and BUF. If REGNUM == -1, transfer all registers
> + belonging to the regset, otherwise just the register numbered
> + REGNUM. The REGSET's 'descr' field must point to an array of
> + 'struct regcache_map_entry'.
IWBN to update the comments to 'descr' field, and go a step further,
rename field 'descr'.
> +
> + These functions are suitable for the 'regset_supply' and
> + 'regset_collect' fields in a regset structure.
> + */
"*/" should go to the previous line.
--
Yao (é½å°§)
next prev parent reply other threads:[~2014-05-27 2:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 16:37 [PATCH 00/12] Regset rework preparations part 2 Andreas Arnez
2014-05-26 16:37 ` [PATCH 12/12] IA64 Linux: Define regset structures Andreas Arnez
2014-05-26 16:37 ` [PATCH 04/12] ALPHA Linux: Fill 'collect_regset' in " Andreas Arnez
2014-05-26 16:37 ` [PATCH 02/12] S390: Migrate to regcache_supply/collect_regset Andreas Arnez
2014-05-26 16:37 ` [PATCH 01/12] regcache: Add functions suitable for regset_supply/collect Andreas Arnez
2014-05-27 2:49 ` Yao Qi [this message]
2014-05-27 11:54 ` Andreas Arnez
2014-05-27 12:22 ` Yao Qi
2014-05-27 14:21 ` Andreas Arnez
2014-05-26 16:37 ` [PATCH 09/12] SCORE: Fill 'collect_regset' in regset structure Andreas Arnez
2014-05-26 16:37 ` [PATCH 06/12] HPPA Linux: Fill 'collect_regset' in regset structures Andreas Arnez
2014-05-26 16:37 ` [PATCH 10/12] TILEGX Linux: Fill 'collect_regset' in regset structure Andreas Arnez
2014-05-26 16:37 ` [PATCH 03/12] AARCH64 Linux: Fill 'collect_regset' in regset structures Andreas Arnez
2014-05-27 21:36 ` Yufeng Zhang
2014-05-26 16:37 ` [PATCH 07/12] M32R Linux: Fill 'collect_regset' in regset structure Andreas Arnez
2014-05-26 16:37 ` [PATCH 05/12] FRV Linux: Fill 'collect_regset' in regset structures Andreas Arnez
2014-05-26 16:37 ` [PATCH 11/12] M68K Linux: Define " Andreas Arnez
2014-05-27 1:37 ` Yao Qi
2014-05-27 8:51 ` Andreas Arnez
2014-05-27 12:48 ` Yao Qi
2014-05-26 16:37 ` [PATCH 08/12] NIOS2 Linux: Fill 'collect_regset' in regset structure Andreas Arnez
2014-05-27 2:15 ` Yao Qi
2014-06-02 9:09 ` Andreas Arnez
2014-05-27 2:56 ` [PATCH 00/12] Regset rework preparations part 2 Yao Qi
2014-05-28 17:36 ` Andreas Arnez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5383FC9B.4040400@codesourcery.com \
--to=yao@codesourcery.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox