From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13821 invoked by alias); 27 May 2014 02:49:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13802 invoked by uid 89); 27 May 2014 02:49:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 May 2014 02:49:16 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1Wp7Rt-0000Iy-4q from Yao_Qi@mentor.com ; Mon, 26 May 2014 19:49:09 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 26 May 2014 19:49:09 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Mon, 26 May 2014 19:49:08 -0700 Message-ID: <5383FC9B.4040400@codesourcery.com> Date: Tue, 27 May 2014 02:49:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Andreas Arnez , Subject: Re: [PATCH 01/12] regcache: Add functions suitable for regset_supply/collect. References: <1401122208-2481-1-git-send-email-arnez@linux.vnet.ibm.com> <1401122208-2481-2-git-send-email-arnez@linux.vnet.ibm.com> In-Reply-To: <1401122208-2481-2-git-send-email-arnez@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00644.txt.bz2 On 05/27/2014 12:36 AM, Andreas Arnez wrote: > +/* Mapping between register numbers and offsets in a buffer, for use > + in the '*regset' functions below. The first entry in a map refers > + to offset 0, and each entry increases the offset by its size. Except that 'regno' is REGCACHE_MAP_SKIP_BYTES. When 'regno' is REGCACHE_MAP_SKIP_BYTES, 'count' is the increased offset by bytes, IIUC. > +/* Transfer a set of registers (as described by REGSET) between > + REGCACHE and BUF. If REGNUM == -1, transfer all registers > + belonging to the regset, otherwise just the register numbered > + REGNUM. The REGSET's 'descr' field must point to an array of > + 'struct regcache_map_entry'. IWBN to update the comments to 'descr' field, and go a step further, rename field 'descr'. > + > + These functions are suitable for the 'regset_supply' and > + 'regset_collect' fields in a regset structure. > + */ "*/" should go to the previous line. -- Yao (齐尧)