Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: gdb-patches@sourceware.org
Cc: Jiong Wang <jiwang@tilera.com>
Subject: [PATCH 10/12] TILEGX Linux: Fill 'collect_regset' in regset structure.
Date: Mon, 26 May 2014 16:37:00 -0000	[thread overview]
Message-ID: <1401122208-2481-11-git-send-email-arnez@linux.vnet.ibm.com> (raw)
In-Reply-To: <1401122208-2481-1-git-send-email-arnez@linux.vnet.ibm.com>

gdb/
	* tilegx-linux-tdep.c (tilegx_linux_supply_regset): Delete
	function.  Move logic to...
	(tilegx_linux_regmap): ... this new register map.
	(TILEGX_GREGS_SIZE): New enum value.
	(tilegx_linux_regset): Refer to register map, replace supply
	method by regcache_supply_regset, and add collect method.
---
 gdb/tilegx-linux-tdep.c | 37 +++++++++++++++----------------------
 1 file changed, 15 insertions(+), 22 deletions(-)

diff --git a/gdb/tilegx-linux-tdep.c b/gdb/tilegx-linux-tdep.c
index 98b03db..4169433 100644
--- a/gdb/tilegx-linux-tdep.c
+++ b/gdb/tilegx-linux-tdep.c
@@ -73,34 +73,27 @@ static const struct tramp_frame tilegx_linux_rt_sigframe =
   tilegx_linux_sigframe_init
 };
 
-/* Supply raw registers from REGCACHE to REGS.  */
+/* Register map; must match struct pt_regs in "ptrace.h".  */
 
-static void
-tilegx_linux_supply_regset (const struct regset *regset,
-			    struct regcache *regcache,
-			    int regnum, const void *regs, size_t len)
-{
-  struct gdbarch *arch = get_regcache_arch (regcache);
-  const char *ptr = regs;
-  int i;
-
-  /* This logic must match that of struct pt_regs in "ptrace.h".  */
-  for (i = 0; i < TILEGX_NUM_EASY_REGS + 2; i++, ptr += tilegx_reg_size)
-    {
-      int gri = (i < TILEGX_NUM_EASY_REGS)
-                 ? i : (i == TILEGX_NUM_EASY_REGS)
-                        ? TILEGX_PC_REGNUM : TILEGX_FAULTNUM_REGNUM;
+static const struct regcache_map_entry tilegx_linux_regmap[] =
+  {
+    { TILEGX_NUM_EASY_REGS, 0 },
+    { 1, TILEGX_PC_REGNUM },
+    { 1, TILEGX_FAULTNUM_REGNUM },
+    { 0 }
+  };
 
-      if (regnum == gri || regnum == -1)
-	regcache_raw_supply (regcache, gri, ptr);
-    }
-}
+enum
+{
+  TILEGX_GREGS_SIZE = (TILEGX_NUM_EASY_REGS + 2) * tilegx_reg_size
+};
 
 /* TILE-Gx Linux kernel register set.  */
+
 static const struct regset tilegx_linux_regset =
 {
-  NULL,
-  tilegx_linux_supply_regset
+  tilegx_linux_regmap,
+  regcache_supply_regset, regcache_collect_regset
 };
 
 static const struct regset *
-- 
1.8.4.2


  parent reply	other threads:[~2014-05-26 16:37 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-26 16:37 [PATCH 00/12] Regset rework preparations part 2 Andreas Arnez
2014-05-26 16:37 ` [PATCH 12/12] IA64 Linux: Define regset structures Andreas Arnez
2014-05-26 16:37 ` [PATCH 04/12] ALPHA Linux: Fill 'collect_regset' in " Andreas Arnez
2014-05-26 16:37 ` [PATCH 09/12] SCORE: Fill 'collect_regset' in regset structure Andreas Arnez
2014-05-26 16:37 ` [PATCH 06/12] HPPA Linux: Fill 'collect_regset' in regset structures Andreas Arnez
2014-05-26 16:37 ` Andreas Arnez [this message]
2014-05-26 16:37 ` [PATCH 01/12] regcache: Add functions suitable for regset_supply/collect Andreas Arnez
2014-05-27  2:49   ` Yao Qi
2014-05-27 11:54     ` Andreas Arnez
2014-05-27 12:22       ` Yao Qi
2014-05-27 14:21         ` Andreas Arnez
2014-05-26 16:37 ` [PATCH 02/12] S390: Migrate to regcache_supply/collect_regset Andreas Arnez
2014-05-26 16:37 ` [PATCH 07/12] M32R Linux: Fill 'collect_regset' in regset structure Andreas Arnez
2014-05-26 16:37 ` [PATCH 03/12] AARCH64 Linux: Fill 'collect_regset' in regset structures Andreas Arnez
2014-05-27 21:36   ` Yufeng Zhang
2014-05-26 16:37 ` [PATCH 08/12] NIOS2 Linux: Fill 'collect_regset' in regset structure Andreas Arnez
2014-05-27  2:15   ` Yao Qi
2014-06-02  9:09     ` Andreas Arnez
2014-05-26 16:37 ` [PATCH 05/12] FRV Linux: Fill 'collect_regset' in regset structures Andreas Arnez
2014-05-26 16:37 ` [PATCH 11/12] M68K Linux: Define " Andreas Arnez
2014-05-27  1:37   ` Yao Qi
2014-05-27  8:51     ` Andreas Arnez
2014-05-27 12:48       ` Yao Qi
2014-05-27  2:56 ` [PATCH 00/12] Regset rework preparations part 2 Yao Qi
2014-05-28 17:36   ` Andreas Arnez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401122208-2481-11-git-send-email-arnez@linux.vnet.ibm.com \
    --to=arnez@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jiwang@tilera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox