From: Luis Machado <lgustavo@codesourcery.com>
To: tmirza <tmirza@codesourcery.com>,
Joel Brobecker <brobecker@adacore.com>
Cc: Will Newton <will.newton@linaro.org>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix prologue analysis for ldr.w and ldrd instruction
Date: Wed, 07 May 2014 15:41:00 -0000 [thread overview]
Message-ID: <536A5437.6080205@codesourcery.com> (raw)
In-Reply-To: <536A5254.3030402@codesourcery.com>
Joel,
On 05/07/2014 12:33 PM, tmirza wrote:
> On 05/07/2014 06:25 PM, Joel Brobecker wrote:
>>>> 2014-05-06 Taimoor Mirza <tmirza@codesourcery.com>
>>>>
>>>> gdb/
>>>> * arm-tdep.c (thumb_analyze_prologue): Fix offset
>>>> calculation for
>>>> ldr.w and ldrd instructions.
>> [...]
>>> This looks good to me, assuming the testsuite was run with no
>>> regressions.
> Thanks for the review Will. Yes I ran testsuites.
>> Thanks, Will, for reviewing the patch. I concur on both counts:
>> patch is approved, but can you please also confirm how the patch
>> was tested?
> I ran testsuites before and after applying my patch and did not find any
> regression.
>>
>> Thank you,
Just for the sake of completeness, the patch was tested against real
boards and a simulator.
Luis
next prev parent reply other threads:[~2014-05-07 15:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 7:41 Taimoor Mirza
2014-05-07 8:01 ` Will Newton
2014-05-07 13:25 ` Joel Brobecker
2014-05-07 15:33 ` tmirza
2014-05-07 15:41 ` Luis Machado [this message]
2014-05-19 15:11 ` Joel Brobecker
2014-05-20 5:19 ` Taimoor
2014-05-20 12:09 ` Joel Brobecker
2014-05-20 13:04 ` Taimoor
2014-05-20 13:18 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536A5437.6080205@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tmirza@codesourcery.com \
--cc=will.newton@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox