From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 946 invoked by alias); 7 May 2014 15:41:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 933 invoked by uid 89); 7 May 2014 15:41:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 May 2014 15:41:56 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1Wi3yj-00054e-7y from Luis_Gustavo@mentor.com ; Wed, 07 May 2014 08:41:53 -0700 Received: from NA1-MAIL.mgc.mentorg.com ([147.34.98.181]) by svr-orw-fem-01.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 7 May 2014 08:41:53 -0700 Received: from [172.30.1.162] ([172.30.1.162]) by NA1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 7 May 2014 08:41:52 -0700 Message-ID: <536A5437.6080205@codesourcery.com> Date: Wed, 07 May 2014 15:41:00 -0000 From: Luis Machado Reply-To: lgustavo@codesourcery.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: tmirza , Joel Brobecker CC: Will Newton , "gdb-patches@sourceware.org" Subject: Re: [PATCH] Fix prologue analysis for ldr.w and ldrd instruction References: <1399448485-1740-1-git-send-email-tmirza@codesourcery.com> <20140507132511.GB4063@adacore.com> <536A5254.3030402@codesourcery.com> In-Reply-To: <536A5254.3030402@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00069.txt.bz2 Joel, On 05/07/2014 12:33 PM, tmirza wrote: > On 05/07/2014 06:25 PM, Joel Brobecker wrote: >>>> 2014-05-06 Taimoor Mirza >>>> >>>> gdb/ >>>> * arm-tdep.c (thumb_analyze_prologue): Fix offset >>>> calculation for >>>> ldr.w and ldrd instructions. >> [...] >>> This looks good to me, assuming the testsuite was run with no >>> regressions. > Thanks for the review Will. Yes I ran testsuites. >> Thanks, Will, for reviewing the patch. I concur on both counts: >> patch is approved, but can you please also confirm how the patch >> was tested? > I ran testsuites before and after applying my patch and did not find any > regression. >> >> Thank you, Just for the sake of completeness, the patch was tested against real boards and a simulator. Luis