Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Will Newton <will.newton@linaro.org>
Cc: Taimoor Mirza <tmirza@codesourcery.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix prologue analysis for ldr.w and ldrd instruction
Date: Wed, 07 May 2014 13:25:00 -0000	[thread overview]
Message-ID: <20140507132511.GB4063@adacore.com> (raw)
In-Reply-To: <CANu=DmgMWP=dr=9xxQxcnFC-99M-BjdZa9JQa8vHM_w8Ythkxg@mail.gmail.com>

> > 2014-05-06  Taimoor Mirza  <tmirza@codesourcery.com>
> >
> >         gdb/
> >         * arm-tdep.c (thumb_analyze_prologue): Fix offset calculation for
> >         ldr.w and ldrd instructions.
[...]
> This looks good to me, assuming the testsuite was run with no regressions.

Thanks, Will, for reviewing the patch. I concur on both counts:
patch is approved, but can you please also confirm how the patch
was tested?

Thank you,
-- 
Joel


  reply	other threads:[~2014-05-07 13:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-07  7:41 Taimoor Mirza
2014-05-07  8:01 ` Will Newton
2014-05-07 13:25   ` Joel Brobecker [this message]
2014-05-07 15:33     ` tmirza
2014-05-07 15:41       ` Luis Machado
2014-05-19 15:11       ` Joel Brobecker
2014-05-20  5:19         ` Taimoor
2014-05-20 12:09           ` Joel Brobecker
2014-05-20 13:04             ` Taimoor
2014-05-20 13:18               ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140507132511.GB4063@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tmirza@codesourcery.com \
    --cc=will.newton@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox