From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19681 invoked by alias); 7 May 2014 13:25:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19664 invoked by uid 89); 7 May 2014 13:25:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 07 May 2014 13:25:14 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7084C1160E1; Wed, 7 May 2014 09:25:12 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id NO1dFKMQTHJS; Wed, 7 May 2014 09:25:12 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 42AB01160D7; Wed, 7 May 2014 09:25:12 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 3308FE0497; Wed, 7 May 2014 06:25:11 -0700 (PDT) Date: Wed, 07 May 2014 13:25:00 -0000 From: Joel Brobecker To: Will Newton Cc: Taimoor Mirza , "gdb-patches@sourceware.org" Subject: Re: [PATCH] Fix prologue analysis for ldr.w and ldrd instruction Message-ID: <20140507132511.GB4063@adacore.com> References: <1399448485-1740-1-git-send-email-tmirza@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-05/txt/msg00064.txt.bz2 > > 2014-05-06 Taimoor Mirza > > > > gdb/ > > * arm-tdep.c (thumb_analyze_prologue): Fix offset calculation for > > ldr.w and ldrd instructions. [...] > This looks good to me, assuming the testsuite was run with no regressions. Thanks, Will, for reviewing the patch. I concur on both counts: patch is approved, but can you please also confirm how the patch was tested? Thank you, -- Joel