From: Pedro Alves <palves@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/2] Extend recognized types of SDT probe's arguments
Date: Fri, 02 May 2014 19:36:00 -0000 [thread overview]
Message-ID: <5363F3A8.8090804@redhat.com> (raw)
In-Reply-To: <m31twc2dal.fsf@redhat.com>
On 05/02/2014 08:25 PM, Sergio Durigan Junior wrote:
> On Friday, May 02 2014, Pedro Alves wrote:
>> I think it'd be good to have a test -- the code that triggered the other
>> bug was also supposedly straightforward. :-) Can we do this in C ?
>> Ideally we'd also test that we don't crash with an invalid bitness
>> (the complaint path).
>
> Hm, OK, here is the testcase then.
Thanks!
> Here is what I will push if there are no other comments.
Looks great.
> This commit extends this. Since this is a straightforward extension,
> I am not submitting a testcase; I can do that if anybody wants.
This sentence is stale. ;-)
--
Pedro Alves
next prev parent reply other threads:[~2014-05-02 19:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-01 21:52 [PATCH 0/2] Fix a bug and extend SDT probe parser Sergio Durigan Junior
2014-05-01 21:52 ` [PATCH 2/2] Extend recognized types of SDT probe's arguments Sergio Durigan Junior
2014-05-02 9:49 ` Pedro Alves
2014-05-02 19:25 ` Sergio Durigan Junior
2014-05-02 19:36 ` Pedro Alves [this message]
2014-05-02 20:57 ` Sergio Durigan Junior
2014-05-01 21:52 ` [PATCH 1/2] Fix PR breakpoints/16889: gdb segfaults when printing ASM SDT arguments Sergio Durigan Junior
2014-05-02 9:44 ` Pedro Alves
2014-05-02 16:14 ` Sergio Durigan Junior
2014-05-02 18:06 ` Sergio Durigan Junior
2014-05-02 18:56 ` Pedro Alves
2014-05-02 20:57 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5363F3A8.8090804@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox