From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30523 invoked by alias); 2 May 2014 19:36:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30511 invoked by uid 89); 2 May 2014 19:36:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 May 2014 19:36:12 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s42JaAU9017105 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 2 May 2014 15:36:10 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s42Ja9pj030140; Fri, 2 May 2014 15:36:09 -0400 Message-ID: <5363F3A8.8090804@redhat.com> Date: Fri, 02 May 2014 19:36:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Sergio Durigan Junior CC: GDB Patches Subject: Re: [PATCH 2/2] Extend recognized types of SDT probe's arguments References: <1398981131-11720-1-git-send-email-sergiodj@redhat.com> <1398981131-11720-3-git-send-email-sergiodj@redhat.com> <53636A1C.8000806@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-05/txt/msg00023.txt.bz2 On 05/02/2014 08:25 PM, Sergio Durigan Junior wrote: > On Friday, May 02 2014, Pedro Alves wrote: >> I think it'd be good to have a test -- the code that triggered the other >> bug was also supposedly straightforward. :-) Can we do this in C ? >> Ideally we'd also test that we don't crash with an invalid bitness >> (the complaint path). > > Hm, OK, here is the testcase then. Thanks! > Here is what I will push if there are no other comments. Looks great. > This commit extends this. Since this is a straightforward extension, > I am not submitting a testcase; I can do that if anybody wants. This sentence is stale. ;-) -- Pedro Alves