Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: David Blaikie <dblaikie@gmail.com>,
	Eric Christopher <echristo@gmail.com>,
	       gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [patch] [gdb/testsuite] include a use of the definition of a type to cause clang to emit debug info
Date: Wed, 23 Apr 2014 23:46:00 -0000	[thread overview]
Message-ID: <535850D3.8000903@redhat.com> (raw)
In-Reply-To: <20140414224702.GT4250@adacore.com>

On 04/14/2014 11:47 PM, Joel Brobecker wrote:
> My position, in this situation, is that your change is actually
> not completely neutral: Even if this was not the initial intention
> when the test was written, as it is now, it allows us to verify
> that the compiler produces the full debugging information for
> an enum type even in the case where the type is only referenced
> through a pointer. By adding a global variable, we lose that part,
> potentially allowing GCC to regress (from a GDB user's perspective).
> 
> If the type was opaque, I would have had no objection. But in this
> case, I try to put myself in the shoes of a user debugging that code,
> and it would seem reasonable to be able to dereference "e".

I think it'd be good if we had a test that exercises that expectation
explicitly.

-- 
Pedro Alves


  reply	other threads:[~2014-04-23 23:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-13  6:43 David Blaikie
2014-04-13  7:52 ` David Blaikie
2014-04-23 23:04   ` Doug Evans
2014-04-14 13:10 ` Joel Brobecker
2014-04-14 15:53   ` Eric Christopher
2014-04-14 18:16     ` Joel Brobecker
2014-04-14 18:35       ` David Blaikie
2014-04-14 22:47         ` Joel Brobecker
2014-04-23 23:46           ` Pedro Alves [this message]
2014-04-24  0:20 ` Doug Evans
2014-04-24  0:29   ` Doug Evans
2014-04-24 12:36     ` Joel Brobecker
2014-04-25  5:32     ` David Blaikie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=535850D3.8000903@redhat.com \
    --to=palves@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=dblaikie@gmail.com \
    --cc=echristo@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox