From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7251 invoked by alias); 23 Apr 2014 23:46:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7241 invoked by uid 89); 23 Apr 2014 23:46:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Apr 2014 23:46:33 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s3NNkT7W022836 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Apr 2014 19:46:29 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s3NNkR7G001316; Wed, 23 Apr 2014 19:46:28 -0400 Message-ID: <535850D3.8000903@redhat.com> Date: Wed, 23 Apr 2014 23:46:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Joel Brobecker CC: David Blaikie , Eric Christopher , gdb-patches Subject: Re: [patch] [gdb/testsuite] include a use of the definition of a type to cause clang to emit debug info References: <20140414131050.GR4250@adacore.com> <20140414181623.GS4250@adacore.com> <20140414224702.GT4250@adacore.com> In-Reply-To: <20140414224702.GT4250@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-04/txt/msg00481.txt.bz2 On 04/14/2014 11:47 PM, Joel Brobecker wrote: > My position, in this situation, is that your change is actually > not completely neutral: Even if this was not the initial intention > when the test was written, as it is now, it allows us to verify > that the compiler produces the full debugging information for > an enum type even in the case where the type is only referenced > through a pointer. By adding a global variable, we lose that part, > potentially allowing GCC to regress (from a GDB user's perspective). > > If the type was opaque, I would have had no objection. But in this > case, I try to put myself in the shoes of a user debugging that code, > and it would seem reasonable to be able to dereference "e". I think it'd be good if we had a test that exercises that expectation explicitly. -- Pedro Alves