Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: David Blaikie <dblaikie@gmail.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [patch] [gdb/testsuite] include a use of the definition of a type to cause clang to emit debug info
Date: Wed, 23 Apr 2014 23:04:00 -0000	[thread overview]
Message-ID: <21336.18170.65952.798538@ruffy.mtv.corp.google.com> (raw)
In-Reply-To: <CAENS6EuydtwiGdk5EK7USRLphkz_0nHG-E+KtWJjC57jDAHehA@mail.gmail.com>

David Blaikie writes:
 > commit 24a8810a97155710d3c53b401eb8729bc4f80c00
 > Author: David Blaikie <dblaikie@gmail.com>
 > Date:   Sun Apr 13 00:48:45 2014 -0700
 > 
 >     Return by value to coax Clang into emitting the full definition of a test type.
 >     
 >     gdb/testsuite/
 >     	* gdb.cp/pr10728-x.cc: Return by value instead of pointer to coax
 >     	Clang into emitting the definition of the type.
 >     	* gdb.cp/pr10728-x.h: Ditto.
 >     	* gdb.cp/pr10728-y.cc: Ditto.

LGTM with one nit.

ChangeLog conventions require one to document the function
in which the change went.
There's plenty of existing boilerplate to copy from.

Thanks!


  reply	other threads:[~2014-04-23 23:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-13  6:43 David Blaikie
2014-04-13  7:52 ` David Blaikie
2014-04-23 23:04   ` Doug Evans [this message]
2014-04-14 13:10 ` Joel Brobecker
2014-04-14 15:53   ` Eric Christopher
2014-04-14 18:16     ` Joel Brobecker
2014-04-14 18:35       ` David Blaikie
2014-04-14 22:47         ` Joel Brobecker
2014-04-23 23:46           ` Pedro Alves
2014-04-24  0:20 ` Doug Evans
2014-04-24  0:29   ` Doug Evans
2014-04-24 12:36     ` Joel Brobecker
2014-04-25  5:32     ` David Blaikie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21336.18170.65952.798538@ruffy.mtv.corp.google.com \
    --to=dje@google.com \
    --cc=dblaikie@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox