From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17961 invoked by alias); 23 Apr 2014 23:04:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17952 invoked by uid 89); 23 Apr 2014 23:04:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f74.google.com Received: from mail-pa0-f74.google.com (HELO mail-pa0-f74.google.com) (209.85.220.74) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 23 Apr 2014 23:04:29 +0000 Received: by mail-pa0-f74.google.com with SMTP id rd3so61168pab.1 for ; Wed, 23 Apr 2014 16:04:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=OlrJYDNfibe33Tg3aY0ocAXzd+zX1Wyy2Wy5M4lmEB0=; b=aGpK6IYGtoBkCWJO67CFxIzjozddF+78EMq7fdQJawG5ePTt+ADPzWPfdmoH6Bu+fm Md6hPxsOKVA/3oOH9bkxWN6whLv7BS4U3tLDMQDNXxVtNMvpqKm2uqu1ATxu2bKZdxEk EHKfCsFvZlWRwBkuKjldolTMaKOSxZZPH3Jg6k1oMsrreR6w8uBuQi0mPlcyu9mrZ4Xg YuRNQk9dpTrCdq0TadQ1AnayHI0MbGku3hPN3/qkgp9Gs1jcsO5cqA3rj4cVxREbhmW6 iTEA8i3PN6pZLCDEsV7JQGVD3dboNjbfsS3X35DwVcj4L+kHJfmi7TXs+40Q2M5hNsGG cypw== X-Gm-Message-State: ALoCoQlUhgBbPnKOQ7i5Ao/WJJRrE3Sup+1PxARRwtiyvdD7cxQVb+20cc2sbZhmXJycvrJnT5SFz4+6W8eamh6YGRwU89AoWcPdedPuEXgLDX7aj2u/B7rD7byBe5x404bjsSpx56pE4MdVVadUVhRd1kO+HwrOVURyUgcePQ30Exk8xXfcsqVj7SBSPcZ0sLsSJSj1IbVh1mJlyvdXH8YRLHHohjLfDA== X-Received: by 10.68.180.132 with SMTP id do4mr10937266pbc.4.1398294267241; Wed, 23 Apr 2014 16:04:27 -0700 (PDT) Received: from corp2gmr1-2.hot.corp.google.com (corp2gmr1-2.hot.corp.google.com [172.24.189.93]) by gmr-mx.google.com with ESMTPS id x22si308193yhd.5.2014.04.23.16.04.27 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 23 Apr 2014 16:04:27 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-2.hot.corp.google.com (Postfix) with ESMTP id 993305A4207; Wed, 23 Apr 2014 16:04:26 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21336.18170.65952.798538@ruffy.mtv.corp.google.com> Date: Wed, 23 Apr 2014 23:04:00 -0000 To: David Blaikie Cc: gdb-patches Subject: Re: [patch] [gdb/testsuite] include a use of the definition of a type to cause clang to emit debug info In-Reply-To: References: X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00476.txt.bz2 David Blaikie writes: > commit 24a8810a97155710d3c53b401eb8729bc4f80c00 > Author: David Blaikie > Date: Sun Apr 13 00:48:45 2014 -0700 > > Return by value to coax Clang into emitting the full definition of a test type. > > gdb/testsuite/ > * gdb.cp/pr10728-x.cc: Return by value instead of pointer to coax > Clang into emitting the definition of the type. > * gdb.cp/pr10728-x.h: Ditto. > * gdb.cp/pr10728-y.cc: Ditto. LGTM with one nit. ChangeLog conventions require one to document the function in which the change went. There's plenty of existing boilerplate to copy from. Thanks!