Re: [PATCH] Remove unused variable

[Simon Marchi <simon.marchi@ericsson.com>]

On 14-04-21 01:14 PM, Joel Brobecker wrote:
>>>> 2014-04-21  Simon Marchi <simon.marchi@ericsson.com>
>>>>
>>>> 	* infrun.c (resume): Remove should_resume (unused).
>>>
>>> Unfortunately, your patch does much much much much much much much
>>> more than just removing "should_resume" :-).
>>>
>>> Can you please submit a patch that just removes that variable?
>>
>> I was afraid it would not be clear and I almost mentioned it in my
>> original message. There are a lot of +/- for a tiny change, because the
>> code looked like that:
>>
>> int should_resume = 1;
>>
>> /* Untouched stuff */
>>
>> if (should_resume)
>>   {
>>     /* Lots of stuff that needs to be unindented. */
>>     ...
>>   }
>>
>> The part that was unindented by four spaces generates a lot of +/-, but
>> I didn't change anything else than that, I swear !
> 
> Indeed. It went a little too fast - what threw me was the addition
> of resume_ptid's declaration at the start of the function. I did
> a quick "git diff -b" and it explains the patch.
> 
> The patch is approved, but we should probably mention the fact that
> resume_ptid's declaration was moved up in the ChangeLog entry.

Would this be a properly formatted CL entry ?

2014-04-21  Simon Marchi <simon.marchi@ericsson.com>

	* infrun.c (resume): Remove should_resume (unused). Move up
	declaration of resume_ptid.

> Here is a link to request an account on sourceware.org, if you do not
> already have one (you can list me as your sponsor):
> https://sourceware.org/cgi-bin/pdw/ps_form.cgi

Done.

> Once that's out of the way, please commit an obvious patch to
> the gdb/MAINTAINERS file adding yourself to the "COMMIT AFTER
> APPROVAL" list (the patch should be treated like all other obvious
> patches, ie a copy should be sent to this mailing-list). Once that's
> all done, then you can push this commit as well. Please remember
> to send a quick confirmation that the commit was pushed to this
> mailing-list as well.
> 
> Thank you,

Ok.

Thanks,

Simon