Re: [PATCH] Remove unused variable

[Simon Marchi <simon.marchi@ericsson.com>]

On 14-04-21 12:12 PM, Joel Brobecker wrote:
> Simon,
> 
>> should_resume is set to 1 at the beginning and never changed.
>>
>> The legal paperwork for people at Ericsson Montreal has been completed
>> last week, so I would be ready to open an account to be able to submit
>> patches.
> 
> Great!
> 
>>
>> gdb/ChangeLog:
>>
>> 2014-04-21  Simon Marchi <simon.marchi@ericsson.com>
>>
>> 	* infrun.c (resume): Remove should_resume (unused).
> 
> Unfortunately, your patch does much much much much much much much
> more than just removing "should_resume" :-).
> 
> Can you please submit a patch that just removes that variable?

I was afraid it would not be clear and I almost mentioned it in my
original message. There are a lot of +/- for a tiny change, because the
code looked like that:

int should_resume = 1;

/* Untouched stuff */

if (should_resume)
  {
    /* Lots of stuff that needs to be unindented. */
    ...
  }

The part that was unindented by four spaces generates a lot of +/-, but
I didn't change anything else than that, I swear !

Simon