From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9262 invoked by alias); 21 Apr 2014 16:54:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9250 invoked by uid 89); 21 Apr 2014 16:54:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 21 Apr 2014 16:54:34 +0000 Received: from EUSAAHC003.ericsson.se (Unknown_Domain [147.117.188.81]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 66.AA.05011.6DEF4535; Mon, 21 Apr 2014 13:19:50 +0200 (CEST) Received: from [142.133.110.254] (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.81) with Microsoft SMTP Server (TLS) id 14.3.174.1; Mon, 21 Apr 2014 12:54:32 -0400 Message-ID: <53554D62.2010901@ericsson.com> Date: Mon, 21 Apr 2014 16:54:00 -0000 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Joel Brobecker CC: GDB Patches Subject: Re: [PATCH] Remove unused variable References: <53553E27.6060009@ericsson.com> <20140421161232.GF4477@adacore.com> In-Reply-To: <20140421161232.GF4477@adacore.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00416.txt.bz2 On 14-04-21 12:12 PM, Joel Brobecker wrote: > Simon, > >> should_resume is set to 1 at the beginning and never changed. >> >> The legal paperwork for people at Ericsson Montreal has been completed >> last week, so I would be ready to open an account to be able to submit >> patches. > > Great! > >> >> gdb/ChangeLog: >> >> 2014-04-21 Simon Marchi >> >> * infrun.c (resume): Remove should_resume (unused). > > Unfortunately, your patch does much much much much much much much > more than just removing "should_resume" :-). > > Can you please submit a patch that just removes that variable? I was afraid it would not be clear and I almost mentioned it in my original message. There are a lot of +/- for a tiny change, because the code looked like that: int should_resume = 1; /* Untouched stuff */ if (should_resume) { /* Lots of stuff that needs to be unindented. */ ... } The part that was unindented by four spaces generates a lot of +/-, but I didn't change anything else than that, I swear ! Simon