From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24737 invoked by alias); 21 Apr 2014 17:36:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24728 invoked by uid 89); 21 Apr 2014 17:36:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 21 Apr 2014 17:36:03 +0000 Received: from EUSAAHC003.ericsson.se (Unknown_Domain [147.117.188.81]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id 5D.D6.06192.52605535; Mon, 21 Apr 2014 13:51:02 +0200 (CEST) Received: from [142.133.110.254] (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.81) with Microsoft SMTP Server (TLS) id 14.3.174.1; Mon, 21 Apr 2014 13:36:01 -0400 Message-ID: <5355571B.1080406@ericsson.com> Date: Mon, 21 Apr 2014 17:36:00 -0000 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Joel Brobecker CC: GDB Patches Subject: Re: [PATCH] Remove unused variable References: <53553E27.6060009@ericsson.com> <20140421161232.GF4477@adacore.com> <53554D62.2010901@ericsson.com> <20140421171453.GA18355@adacore.com> In-Reply-To: <20140421171453.GA18355@adacore.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00418.txt.bz2 On 14-04-21 01:14 PM, Joel Brobecker wrote: >>>> 2014-04-21 Simon Marchi >>>> >>>> * infrun.c (resume): Remove should_resume (unused). >>> >>> Unfortunately, your patch does much much much much much much much >>> more than just removing "should_resume" :-). >>> >>> Can you please submit a patch that just removes that variable? >> >> I was afraid it would not be clear and I almost mentioned it in my >> original message. There are a lot of +/- for a tiny change, because the >> code looked like that: >> >> int should_resume = 1; >> >> /* Untouched stuff */ >> >> if (should_resume) >> { >> /* Lots of stuff that needs to be unindented. */ >> ... >> } >> >> The part that was unindented by four spaces generates a lot of +/-, but >> I didn't change anything else than that, I swear ! > > Indeed. It went a little too fast - what threw me was the addition > of resume_ptid's declaration at the start of the function. I did > a quick "git diff -b" and it explains the patch. > > The patch is approved, but we should probably mention the fact that > resume_ptid's declaration was moved up in the ChangeLog entry. Would this be a properly formatted CL entry ? 2014-04-21 Simon Marchi * infrun.c (resume): Remove should_resume (unused). Move up declaration of resume_ptid. > Here is a link to request an account on sourceware.org, if you do not > already have one (you can list me as your sponsor): > https://sourceware.org/cgi-bin/pdw/ps_form.cgi Done. > Once that's out of the way, please commit an obvious patch to > the gdb/MAINTAINERS file adding yourself to the "COMMIT AFTER > APPROVAL" list (the patch should be treated like all other obvious > patches, ie a copy should be sent to this mailing-list). Once that's > all done, then you can push this commit as well. Please remember > to send a quick confirmation that the commit was pushed to this > mailing-list as well. > > Thank you, Ok. Thanks, Simon