From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Pierre Langlois <pierre.langlois@embecosm.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH][PR breakpoints/16606] AVR8 breakpoint out of range, decrement pc after break
Date: Mon, 10 Mar 2014 17:07:00 -0000 [thread overview]
Message-ID: <531DF151.1010606@redhat.com> (raw)
In-Reply-To: <20140310110809.GC4882@adacore.com>
On 03/10/2014 11:08 AM, Joel Brobecker wrote:
>> @@ -1436,6 +1439,7 @@ avr_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
>> set_gdbarch_inner_than (gdbarch, core_addr_lessthan);
>>
>> set_gdbarch_breakpoint_from_pc (gdbarch, avr_breakpoint_from_pc);
>> + set_gdbarch_decr_pc_after_break (gdbarch, 2);
>
> This part seems fine, but it would be good if you could submit it
> separately, with an explanation of the problem you are seeing
> (a copy of the gdb debugging session is often useful).
Yes please. I'm quite mystified that only 'b *0xaddr' exposed the need
for this. If PC adjustment is really necessary on this architecture,
then I can't imagine how the port managed to be functional thus
far without this.
--
Pedro Alves
next prev parent reply other threads:[~2014-03-10 17:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 19:50 Pierre Langlois
2014-03-10 9:23 ` Pierre Langlois
2014-03-10 11:08 ` Joel Brobecker
2014-03-10 17:07 ` Pedro Alves [this message]
2014-03-11 11:58 ` Pierre Langlois
2014-03-12 8:08 ` Joel Brobecker
2014-03-13 14:05 ` Pierre Langlois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531DF151.1010606@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.langlois@embecosm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox