From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11098 invoked by alias); 10 Mar 2014 17:07:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10988 invoked by uid 89); 10 Mar 2014 17:07:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Mar 2014 17:07:35 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2AH7VN2023890 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 10 Mar 2014 13:07:31 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s2AH7TWs022513; Mon, 10 Mar 2014 13:07:30 -0400 Message-ID: <531DF151.1010606@redhat.com> Date: Mon, 10 Mar 2014 17:07:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Joel Brobecker CC: Pierre Langlois , gdb-patches@sourceware.org Subject: Re: [PATCH][PR breakpoints/16606] AVR8 breakpoint out of range, decrement pc after break References: <531A2316.5090507@embecosm.com> <20140310110809.GC4882@adacore.com> In-Reply-To: <20140310110809.GC4882@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-03/txt/msg00246.txt.bz2 On 03/10/2014 11:08 AM, Joel Brobecker wrote: >> @@ -1436,6 +1439,7 @@ avr_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) >> set_gdbarch_inner_than (gdbarch, core_addr_lessthan); >> >> set_gdbarch_breakpoint_from_pc (gdbarch, avr_breakpoint_from_pc); >> + set_gdbarch_decr_pc_after_break (gdbarch, 2); > > This part seems fine, but it would be good if you could submit it > separately, with an explanation of the problem you are seeing > (a copy of the gdb debugging session is often useful). Yes please. I'm quite mystified that only 'b *0xaddr' exposed the need for this. If PC adjustment is really necessary on this architecture, then I can't imagine how the port managed to be functional thus far without this. -- Pedro Alves