From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/6] Fix missing breakpoing/watchpoint hits, eliminate deferred_step_ptid.
Date: Wed, 05 Mar 2014 16:10:00 -0000 [thread overview]
Message-ID: <53174C55.5050808@redhat.com> (raw)
In-Reply-To: <53156C94.40009@codesourcery.com>
On 03/04/2014 06:03 AM, Yao Qi wrote:
> I don't have much comments on the patch, just some nits on tests:
>
> On 02/26/2014 04:32 AM, Pedro Alves wrote:
>> + gdb_test "set scheduler-locking off"
>
> Use "gdb_test_no_output"?
>
>> + gdb_test "info breakpoints"
>> + gdb_test "set debug infrun 1"
>
> I don't see the purpose of doing these two tests.
It was handy to have them there while working on the patch,
and I forgot to remove them.
>
> They apply to step-over-lands-on-watchpoint.exp too.
>
Fixed in v2.
Thanks!
--
Pedro Alves
next prev parent reply other threads:[~2014-03-05 16:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 20:32 [PATCH 0/6] Fix a bunch of run control bugs Pedro Alves
2014-02-25 20:32 ` [PATCH 3/6] Fix missing breakpoing/watchpoint hits, eliminate deferred_step_ptid Pedro Alves
2014-03-04 6:05 ` Yao Qi
2014-03-05 16:10 ` Pedro Alves [this message]
2014-02-25 20:32 ` [PATCH 2/6] PR breakpoints/7143 - Watchpoint does not trigger when first set Pedro Alves
2014-03-05 15:35 ` Pedro Alves
2014-02-25 20:32 ` [PATCH 1/6] PR gdb/16575: stale breakpoint instructions in the code cache Pedro Alves
2014-03-04 4:02 ` Yao Qi
2014-03-05 15:13 ` Pedro Alves
2014-03-05 15:14 ` Pedro Alves
2014-02-25 20:33 ` [PATCH 4/6] Fix for even more missed events; eliminate thread-hop code Pedro Alves
2014-03-05 15:45 ` Pedro Alves
2014-02-25 20:33 ` [PATCH 5/6] Handle multiple step-overs Pedro Alves
2014-02-25 21:08 ` [PATCH 6/6] Make signal-while-stepping-over-bp-other-thread.exp run against remote targets too Pedro Alves
2014-02-26 13:36 ` [PATCH 3.5/6] Multiple Ada task-specific breakpoints at the same address Pedro Alves
2014-02-26 14:19 ` Joel Brobecker
2014-02-26 14:27 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53174C55.5050808@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox