From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17814 invoked by alias); 5 Mar 2014 16:10:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17803 invoked by uid 89); 5 Mar 2014 16:10:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Mar 2014 16:10:17 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s25G9xQL011062 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 5 Mar 2014 11:10:00 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s25G9vQx005818; Wed, 5 Mar 2014 11:09:58 -0500 Message-ID: <53174C55.5050808@redhat.com> Date: Wed, 05 Mar 2014 16:10:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 3/6] Fix missing breakpoing/watchpoint hits, eliminate deferred_step_ptid. References: <1393360363-5603-1-git-send-email-palves@redhat.com> <1393360363-5603-4-git-send-email-palves@redhat.com> <53156C94.40009@codesourcery.com> In-Reply-To: <53156C94.40009@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-03/txt/msg00127.txt.bz2 On 03/04/2014 06:03 AM, Yao Qi wrote: > I don't have much comments on the patch, just some nits on tests: > > On 02/26/2014 04:32 AM, Pedro Alves wrote: >> + gdb_test "set scheduler-locking off" > > Use "gdb_test_no_output"? > >> + gdb_test "info breakpoints" >> + gdb_test "set debug infrun 1" > > I don't see the purpose of doing these two tests. It was handy to have them there while working on the patch, and I forgot to remove them. > > They apply to step-over-lands-on-watchpoint.exp too. > Fixed in v2. Thanks! -- Pedro Alves