From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3.5/6] Multiple Ada task-specific breakpoints at the same address.
Date: Wed, 26 Feb 2014 14:19:00 -0000 [thread overview]
Message-ID: <20140226141901.GD4348@adacore.com> (raw)
In-Reply-To: <530DEDCD.9080207@redhat.com>
Hi Pedro,
> gdb/
> 2014-02-26 Pedro Alves <palves@redhat.com>
>
> * breakpoint.c (bpstat_check_breakpoint_conditions): Handle
> task-specific breakpoints.
Interesting bug.
> gdb/testsuite/
> 2014-02-26 Pedro Alves <palves@redhat.com>
>
> * gdb.ada/tasks.exp: Set a task-specific breakpoint at break_me
> that won't ever trigger. Make sure that GDB reports the correct
> breakpoint that caused the stop.
It all looks good to me. Just a few nits I happen to notice:
> +# Insert a breakpoint that should stop only if task 1 stops. Since
> +# task 1 never calls break_me, this shouldn't actually ever trigger.
> +# The fact this this breakpoint is created _before_ the next one
^^^^^^^^^
that this?
> +# matter. GDB used to have a bug where it would report the first
^^^^^^
matters
Thank you,
--
Joel
next prev parent reply other threads:[~2014-02-26 14:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 20:32 [PATCH 0/6] Fix a bunch of run control bugs Pedro Alves
2014-02-25 20:32 ` [PATCH 1/6] PR gdb/16575: stale breakpoint instructions in the code cache Pedro Alves
2014-03-04 4:02 ` Yao Qi
2014-03-05 15:13 ` Pedro Alves
2014-03-05 15:14 ` Pedro Alves
2014-02-25 20:32 ` [PATCH 2/6] PR breakpoints/7143 - Watchpoint does not trigger when first set Pedro Alves
2014-03-05 15:35 ` Pedro Alves
2014-02-25 20:32 ` [PATCH 3/6] Fix missing breakpoing/watchpoint hits, eliminate deferred_step_ptid Pedro Alves
2014-03-04 6:05 ` Yao Qi
2014-03-05 16:10 ` Pedro Alves
2014-02-25 20:33 ` [PATCH 5/6] Handle multiple step-overs Pedro Alves
2014-02-25 20:33 ` [PATCH 4/6] Fix for even more missed events; eliminate thread-hop code Pedro Alves
2014-03-05 15:45 ` Pedro Alves
2014-02-25 21:08 ` [PATCH 6/6] Make signal-while-stepping-over-bp-other-thread.exp run against remote targets too Pedro Alves
2014-02-26 13:36 ` [PATCH 3.5/6] Multiple Ada task-specific breakpoints at the same address Pedro Alves
2014-02-26 14:19 ` Joel Brobecker [this message]
2014-02-26 14:27 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140226141901.GD4348@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox