From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30954 invoked by alias); 26 Feb 2014 14:19:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30944 invoked by uid 89); 26 Feb 2014 14:19:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 26 Feb 2014 14:19:04 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 24C3E116218; Wed, 26 Feb 2014 09:19:03 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ealHLnIuD-jh; Wed, 26 Feb 2014 09:19:03 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id F18651161D1; Wed, 26 Feb 2014 09:19:02 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id B733EE10D9; Wed, 26 Feb 2014 06:19:01 -0800 (PST) Date: Wed, 26 Feb 2014 14:19:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3.5/6] Multiple Ada task-specific breakpoints at the same address. Message-ID: <20140226141901.GD4348@adacore.com> References: <1393360363-5603-1-git-send-email-palves@redhat.com> <530DEDCD.9080207@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <530DEDCD.9080207@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-02/txt/msg00781.txt.bz2 Hi Pedro, > gdb/ > 2014-02-26 Pedro Alves > > * breakpoint.c (bpstat_check_breakpoint_conditions): Handle > task-specific breakpoints. Interesting bug. > gdb/testsuite/ > 2014-02-26 Pedro Alves > > * gdb.ada/tasks.exp: Set a task-specific breakpoint at break_me > that won't ever trigger. Make sure that GDB reports the correct > breakpoint that caused the stop. It all looks good to me. Just a few nits I happen to notice: > +# Insert a breakpoint that should stop only if task 1 stops. Since > +# task 1 never calls break_me, this shouldn't actually ever trigger. > +# The fact this this breakpoint is created _before_ the next one ^^^^^^^^^ that this? > +# matter. GDB used to have a bug where it would report the first ^^^^^^ matters Thank you, -- Joel