Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Andreas Arnez <arnez@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org, Ulrich Weigand <uweigand@de.ibm.com>,
	       Andreas Krebbel <krebbel@linux.vnet.ibm.com>,
	       Yao Qi <yao@codesourcery.com>
Subject: Re: [PATCH] Fix length arg in call to breakpoint_xfer_memory
Date: Fri, 21 Feb 2014 13:56:00 -0000	[thread overview]
Message-ID: <53075B09.3000604@redhat.com> (raw)
In-Reply-To: <87ios8fwf9.fsf@br87z6lw.de.ibm.com>

On 02/21/2014 01:05 PM, Andreas Arnez wrote:
> The patch "return target_xfer_status in to_xfer_partial" caused a
> regression in various s390(x) test cases, because memory_xfer_partial
> filled only the first byte of the read buffer from a breakpoint shadow:

Ah.  Breakpoints on x86 happen to be 1 byte long.  How lucky.  :-)

> 
>     https://sourceware.org/ml/gdb-patches/2014-01/msg01071.html
> 
> This patch fixes the regression.
> 
> ChangeLog/
> 	* target.c (memory_xfer_partial): Fix length arg in call to
> 	breakpoint_xfer_memory.

OK.

Thanks,
-- 
Pedro Alves


  parent reply	other threads:[~2014-02-21 13:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-21 13:05 Andreas Arnez
2014-02-21 13:22 ` Yao Qi
2014-02-21 13:56 ` Pedro Alves [this message]
2014-02-21 15:02 ` Andreas Krebbel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53075B09.3000604@redhat.com \
    --to=palves@redhat.com \
    --cc=arnez@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=krebbel@linux.vnet.ibm.com \
    --cc=uweigand@de.ibm.com \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox