From: Yao Qi <yao@codesourcery.com>
To: Andreas Arnez <arnez@linux.vnet.ibm.com>
Cc: <gdb-patches@sourceware.org>,
Ulrich Weigand <uweigand@de.ibm.com>,
Andreas Krebbel <krebbel@linux.vnet.ibm.com>
Subject: Re: [PATCH] Fix length arg in call to breakpoint_xfer_memory
Date: Fri, 21 Feb 2014 13:22:00 -0000 [thread overview]
Message-ID: <53075287.8000207@codesourcery.com> (raw)
In-Reply-To: <87ios8fwf9.fsf@br87z6lw.de.ibm.com>
On 02/21/2014 09:05 PM, Andreas Arnez wrote:
> @@ -1348,7 +1348,7 @@ memory_xfer_partial (struct target_ops *ops, enum target_object object,
> xfered_len);
>
> if (res == TARGET_XFER_OK && !show_memory_breakpoints)
> - breakpoint_xfer_memory (readbuf, NULL, NULL, memaddr, res);
> + breakpoint_xfer_memory (readbuf, NULL, NULL, memaddr, *xfered_len);
Ah, it should be "*xfered_len" instead of "res". The patch looks good
to me, but I can't approve it.
--
Yao (é½å°§)
next prev parent reply other threads:[~2014-02-21 13:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 13:05 Andreas Arnez
2014-02-21 13:22 ` Yao Qi [this message]
2014-02-21 13:56 ` Pedro Alves
2014-02-21 15:02 ` Andreas Krebbel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53075287.8000207@codesourcery.com \
--to=yao@codesourcery.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=krebbel@linux.vnet.ibm.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox