From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9527 invoked by alias); 21 Feb 2014 13:22:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9511 invoked by uid 89); 21 Feb 2014 13:22:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Feb 2014 13:22:30 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WGq3d-0001Ko-Oa from Yao_Qi@mentor.com ; Fri, 21 Feb 2014 05:22:25 -0800 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 21 Feb 2014 05:22:25 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.2.247.3; Fri, 21 Feb 2014 05:21:38 -0800 Message-ID: <53075287.8000207@codesourcery.com> Date: Fri, 21 Feb 2014 13:22:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Andreas Arnez CC: , Ulrich Weigand , Andreas Krebbel Subject: Re: [PATCH] Fix length arg in call to breakpoint_xfer_memory References: <87ios8fwf9.fsf@br87z6lw.de.ibm.com> In-Reply-To: <87ios8fwf9.fsf@br87z6lw.de.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00691.txt.bz2 On 02/21/2014 09:05 PM, Andreas Arnez wrote: > @@ -1348,7 +1348,7 @@ memory_xfer_partial (struct target_ops *ops, enum target_object object, > xfered_len); > > if (res == TARGET_XFER_OK && !show_memory_breakpoints) > - breakpoint_xfer_memory (readbuf, NULL, NULL, memaddr, res); > + breakpoint_xfer_memory (readbuf, NULL, NULL, memaddr, *xfered_len); Ah, it should be "*xfered_len" instead of "res". The patch looks good to me, but I can't approve it. -- Yao (齐尧)