From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3190 invoked by alias); 21 Feb 2014 13:56:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3181 invoked by uid 89); 21 Feb 2014 13:56:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Feb 2014 13:56:34 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1LDuSwP007282 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 21 Feb 2014 08:56:28 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s1LDuPHn019742; Fri, 21 Feb 2014 08:56:26 -0500 Message-ID: <53075B09.3000604@redhat.com> Date: Fri, 21 Feb 2014 13:56:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Andreas Arnez CC: gdb-patches@sourceware.org, Ulrich Weigand , Andreas Krebbel , Yao Qi Subject: Re: [PATCH] Fix length arg in call to breakpoint_xfer_memory References: <87ios8fwf9.fsf@br87z6lw.de.ibm.com> In-Reply-To: <87ios8fwf9.fsf@br87z6lw.de.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-02/txt/msg00694.txt.bz2 On 02/21/2014 01:05 PM, Andreas Arnez wrote: > The patch "return target_xfer_status in to_xfer_partial" caused a > regression in various s390(x) test cases, because memory_xfer_partial > filled only the first byte of the read buffer from a breakpoint shadow: Ah. Breakpoints on x86 happen to be 1 byte long. How lucky. :-) > > https://sourceware.org/ml/gdb-patches/2014-01/msg01071.html > > This patch fixes the regression. > > ChangeLog/ > * target.c (memory_xfer_partial): Fix length arg in call to > breakpoint_xfer_memory. OK. Thanks, -- Pedro Alves