From: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] testsuite: Fix gdb.dwarf2/dw2-case-insensitive.exp testcase for ppc64
Date: Tue, 28 Jan 2014 18:20:00 -0000 [thread overview]
Message-ID: <52E7F4CF.9070803@linux.vnet.ibm.com> (raw)
In-Reply-To: <201401281601.s0SG1lJW004119@d06av02.portsmouth.uk.ibm.com>
On 01/28/2014 02:01 PM, Ulrich Weigand wrote:
> If the problem is indeed that FUNC_lang_end is at the same location as
> FUNC_symtab, maybe a better fix would be to add some padding in between
> (e.g. a ".byte 0" after the FUNC_lang_end label)?
Thanks Uli for the review. I've tested your suggestion and it fixed the problem
on ppc64. It was also successfully tested on x86.
If someone could take a look and check if this change doesn't affect the results
on arm, that would be great.
Thanks,
--
Edjunior
gdb/testsuite/
2014-01-28 Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
* gdb.dwarf2/dw2-case-insensitive.c: Add padding after FUNC_lang_end
label.
---
gdb/testsuite/gdb.dwarf2/dw2-case-insensitive.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-case-insensitive.c b/gdb/testsuite/gdb.dwarf2/dw2-case-insensitive.c
index 9ec7b25..48a0694 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-case-insensitive.c
+++ b/gdb/testsuite/gdb.dwarf2/dw2-case-insensitive.c
@@ -30,6 +30,7 @@ FUNC_lang (void)
asm (".globl FUNC_lang_end");
asm ("FUNC_lang_end:");
+asm (".byte 0");
/* Symbol is present only in ELF .symtab. */
--
1.7.9.5
prev parent reply other threads:[~2014-01-28 18:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 14:42 Edjunior Barbosa Machado
2014-01-23 15:54 ` Will Newton
2014-01-28 16:01 ` Ulrich Weigand
2014-01-28 18:20 ` Edjunior Barbosa Machado [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E7F4CF.9070803@linux.vnet.ibm.com \
--to=emachado@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox