Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] testsuite: Fix gdb.dwarf2/dw2-case-insensitive.exp testcase for ppc64
Date: Thu, 23 Jan 2014 14:42:00 -0000	[thread overview]
Message-ID: <1390488123-2421-1-git-send-email-emachado@linux.vnet.ibm.com> (raw)

Hi,

gdb.dwarf2/dw2-case-insensitive.exp has currently 1 test failing on ppc64:

p fuNC_symtab^M
$2 = {<text variable, no debug info>} 0x10000694 <FUNC_lang_end>^M
(gdb) FAIL: gdb.dwarf2/dw2-case-insensitive.exp: p fuNC_symtab

This regression was introduced after a change in the testcase that added
function labels to the code, fixing failures on arm (commit
c7e8af9b3bc0881c59c999d7b78348d359383efe).

This patch moves the label FUNC_lang_end to the end of the function scope, so
ppc64 can understand the following function (fuNC_symtab) correctly.
Successfully tested on x86, ppc32 and ppc64, but didn't have the chance to check
on arm.

Thanks,
Edjunior

gdb/testsuite/
2014-01-23  Edjunior Barbosa Machado  <emachado@linux.vnet.ibm.com>

	* gdb.dwarf2/dw2-case-insensitive.c (FUNC_lang): Move label
	FUNC_lang_end.

---
 gdb/testsuite/gdb.dwarf2/dw2-case-insensitive.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.dwarf2/dw2-case-insensitive.c b/gdb/testsuite/gdb.dwarf2/dw2-case-insensitive.c
index 9ec7b25..bdeee1e 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-case-insensitive.c
+++ b/gdb/testsuite/gdb.dwarf2/dw2-case-insensitive.c
@@ -26,10 +26,9 @@ asm ("FUNC_lang_start:");
 void
 FUNC_lang (void)
 {
-}
-
 asm (".globl FUNC_lang_end");
 asm ("FUNC_lang_end:");
+}
 
 /* Symbol is present only in ELF .symtab.  */
 
-- 
1.8.1.4


             reply	other threads:[~2014-01-23 14:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-23 14:42 Edjunior Barbosa Machado [this message]
2014-01-23 15:54 ` Will Newton
2014-01-28 16:01 ` Ulrich Weigand
2014-01-28 18:20   ` Edjunior Barbosa Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1390488123-2421-1-git-send-email-emachado@linux.vnet.ibm.com \
    --to=emachado@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox